Skip to content

Conversation

@dimitryc
Copy link
Contributor

@dimitryc dimitryc commented Dec 20, 2022

Please review the update of timezone data to 2022g.

The existing data was replaced with the new data generated from tzdb-2022g in the rearguard format. This also includes updating a copy of the data in tests (jdk/test/sun/util/calendar/zi/tzdata).

Other parts apply cleanly (with path changes) except timezone.xml. It's added as a part JDK-8186697 (appeared since 10). So changes in timezone.xml ignored.

Testing: all relevant tests passed jdk/test/java/util/TimeZone, jdk/test/sun/util/calendar and jdk/test/java/time/test


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u pull/26/head:pull/26
$ git checkout pull/26

Update a local copy of the PR:
$ git checkout pull/26
$ git pull https://git.openjdk.org/jdk8u pull/26/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26

View PR using the GUI difftool:
$ git pr show -t 26

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u/pull/26.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 20, 2022

👋 Welcome back dcherepanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ce896731d38866c2bf99cd49525062e150d94160 8297804: (tz) Update Timezone Data to 2022g Dec 20, 2022
@openjdk
Copy link

openjdk bot commented Dec 20, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Dec 20, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 20, 2022

Webrevs

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks the same as what I have here - #28 - except you haven't adjusted for the absence of Mexico_Pacific. Note also that mine is built on top of #27 which adds CLDR adjustments for the previous update, 2022f.

Reviews of those PRs are welcome.

@dimitryc
Copy link
Contributor Author

This looks the same as what I have here - #28 - except you haven't adjusted for the absence of Mexico_Pacific. Note also that mine is built on top of #27 which adds CLDR adjustments for the previous update, 2022f.

Reviews of those PRs are welcome.

These PRs look good. Thank you.

@dimitryc dimitryc closed this Dec 21, 2022
@gnu-andrew
Copy link
Member

This looks the same as what I have here - #28 - except you haven't adjusted for the absence of Mexico_Pacific. Note also that mine is built on top of #27 which adds CLDR adjustments for the previous update, 2022f.
Reviews of those PRs are welcome.

These PRs look good. Thank you.

Thanks. Sorry for the duplication. I didn't see your PR until I'd just finished testing my 2022g patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants