Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR #29

Closed
wants to merge 1 commit into from

Conversation

jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Dec 22, 2022

Please review this critical fix which fixes a regression introduced with with JDK-8269039: Disable SHA-1 Signed JARs which was included in 8u362 (note that 8u352 is not affected as JDK-8269039 is not there). This should be low-risk as it mainly removes use of java.util.Calendar API usage in DisabledAlgorithmConstraints which can cause issues with applications that contain CalendarDataProviders in signed jars.

Proposing as critical fix so that we don't regress in that regard in 8u362.

Please review this backport. The changes in keytool/Main.java didn't apply. Those aren't critical changes for this patch, so I've omitted them. In addition, the test needed some changes to make it work with JDK 8 (comparing to the 11u version). Used IOUtils.readAllBytes() over InputStream.readAllBytes() in the custom classloader class, fixed some test lib imports and declared Throwable to be thrown in main as ProcessTools.executeProcess throws Throwable over Exception in 8u.

Regression test fails prior (current jdk8u tree, without this patch) and passes after the product fix.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u pull/29/head:pull/29
$ git checkout pull/29

Update a local copy of the PR:
$ git checkout pull/29
$ git pull https://git.openjdk.org/jdk8u pull/29/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29

View PR using the GUI difftool:
$ git pr show -t 29

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u/pull/29.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 22, 2022

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a0f6f2409ea61ff9ed9dc2e2b46e309c751d456d 8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR Dec 22, 2022
@openjdk
Copy link

openjdk bot commented Dec 22, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Dec 22, 2022
@jerboaa
Copy link
Contributor Author

jerboaa commented Dec 22, 2022

@gnu-andrew @martinuy Can you please help review this? Thanks!

@mlbridge
Copy link

mlbridge bot commented Dec 22, 2022

Webrevs

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The keytool changes are from JDK-8273236, another recent fix relating to this SHA-1 deprecation. If the SHA-1 deprecation itself had been integrated a bit earlier, it might have made 8u362.

I don't think that's critical enough to try and get in at this stage [edit: to clarify, I mean JDK-8273236]. I'll propose it for 8u-dev in the new year with the removals from this patch omitted.

The other changes look sensible. Can you enable actions so that builds & tests are run? Once they look good, I'll approve. Thanks.

@jerboaa
Copy link
Contributor Author

jerboaa commented Dec 23, 2022

The keytool changes are from JDK-8273236, another recent fix relating to this SHA-1 deprecation. If the SHA-1 deprecation itself had been integrated a bit earlier, it might have made 8u362.

I don't think that's critical enough to try and get in at this stage. I'll propose it for 8u-dev in the new year with the removals from this patch omitted.

The other changes look sensible. Can you enable actions so that builds & tests are run? Once they look good, I'll approve. Thanks.

OK

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@openjdk
Copy link

openjdk bot commented Dec 23, 2022

@jerboaa This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 23, 2022
@jerboaa
Copy link
Contributor Author

jerboaa commented Dec 23, 2022

Thanks for the review, labelled the bug jdk8u-critical-request now.

@gnu-andrew
Copy link
Member

JDK-8273236

Thanks for the review, labelled the bug jdk8u-critical-request now.

And approved.

@jerboaa
Copy link
Contributor Author

jerboaa commented Dec 23, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Dec 23, 2022

Going to push as commit ebc5e19.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 23, 2022
@openjdk openjdk bot closed this Dec 23, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 23, 2022
@openjdk
Copy link

openjdk bot commented Dec 23, 2022

@jerboaa Pushed as commit ebc5e19.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants