8303828: [Solaris] Broken jdk8u build after JDK-8266391

[adamfarley]

Because Solaris currently lacks this class, the build breaks when compiling Metrics.java. Inserting a dummy class to fix that.

This takes the same approach as JDK-8303408, only on Solaris.

This change is being proposed directly to JDK8u because I'm not aware of Solaris platform support post-JDK8.

P.S. This PR is being created for jdk8u (as well as jdk8u-dev) as per this advice here.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8303828: [Solaris] Broken jdk8u build after JDK-8266391

Reviewers

• Severin Gehwolf (@jerboaa - Reviewer)
• Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u pull/37/head:pull/37
$ git checkout pull/37

Update a local copy of the PR:
$ git checkout pull/37
$ git pull https://git.openjdk.org/jdk8u pull/37/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 37

View PR using the GUI difftool:
$ git pr show -t 37

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u/pull/37.diff

[bridgekeeper]

👋 Welcome back afarley! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[jerboaa]

Please change the PR title to 8303828: [Solaris] Broken jdk8u build after JDK-8266391 so that it matches the JBS issue. Then, please enable testing on your fork. See Details link in Pre-submit test status which has instructions. Finally, switch the approval labels to jdk8u-critical-request (from jdk8u-fix-request). Thanks!

[jerboaa]

LGTM.

[openjdk]

@adamfarley This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8303828: [Solaris] Broken jdk8u build after JDK-8266391

Reviewed-by: sgehwolf, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa, @gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (8caab5d9)

[jerboaa]

@adamfarley The bug is approved, feel free to /integrate

[adamfarley]

Thanks Severin. :)

[adamfarley]

/integrate

[openjdk]

@adamfarley
Your change (at version 8caab5d) is now ready to be sponsored by a Committer.

[gnu-andrew]

Makes sense. I guess we should have expected this after the AIX one. At least now we know who to contact for future issues that touch Solaris and AIX!

[gnu-andrew]

@adamfarley, doesn't matter for this one (as the testers don't build on Solaris anyway obviously), but you should make sure to enable GitHub Actions in your fork for any future changes, so testing will run.

[gnu-andrew]

/sponsor

[openjdk]

Going to push as commit ebbd3a8.

[openjdk]

@gnu-andrew @adamfarley Pushed as commit ebbd3a8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[jerboaa]

This seems to have broken the build on linux and apparently on mac os on the rampdown tree. The issue seems to be that on the old build system solaris/classes are being merged on mac/linux/aix as well. So while it fixes the solaris build it breaks linux and mac. GHA would have caught it. Sigh.

[gnu-andrew]

This seems to have broken the build on linux and apparently on mac os on the rampdown tree. The issue seems to be that on the old build system solaris/classes are being merged on mac/linux/aix as well. So while it fixes the solaris build it breaks linux and mac. GHA would have caught it. Sigh.

My bad. I should have required that run before allowing this one. It completely slipped my mind that the solaris directory was the generic directory on 8u and older.

[jerboaa]

This seems to have broken the build on linux and apparently on mac os on the rampdown tree. The issue seems to be that on the old build system solaris/classes are being merged on mac/linux/aix as well. So while it fixes the solaris build it breaks linux and mac. GHA would have caught it. Sigh.

My bad. I should have required that run before allowing this one. It completely slipped my mind that the solaris directory was the generic directory on 8u and older.

No worries. This solaris peculiarity slipped my mind as well...