New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8225687: Newly added sspi.cpp in JDK-6722928 still contains some small errors #47
Conversation
👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@gnu-andrew Could you please review, so it could be added to 8u392 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backport looks clean and tests pass.
Please add jdk8u-critical-request
to the bug and an appropriate comment, and I'll approve for 8u392. Thanks.
@alexeybakhtin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 599bb77. |
@alexeybakhtin Pushed as commit 599bb77. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This is a follow-up fix for JDK-6722928.
Clean backport from JDK11
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u.git pull/47/head:pull/47
$ git checkout pull/47
Update a local copy of the PR:
$ git checkout pull/47
$ git pull https://git.openjdk.org/jdk8u.git pull/47/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 47
View PR using the GUI difftool:
$ git pr show -t 47
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u/pull/47.diff
Webrev
Link to Webrev Comment