-
Notifications
You must be signed in to change notification settings - Fork 229
8314960: Add Certigna Root CA - 2 #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
|
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout JDK-8314960-certigna-root-ca-2
git fetch https://git.openjdk.org/jdk8u.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
c8e4d16 to
1d96183
Compare
|
@jerboaa Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
|
@gnu-andrew Ready for you to review, please! |
gnu-andrew
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patch looks clean. Approved for 8u392.
|
@jerboaa This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit b24b03f.
Your commit was automatically rebased without conflicts. |
Backport of JDK-8314960 to add new certigna root 2 certificate to OpenJDK 8u392 as a critical fix during rampdown. Patch applies cleanly after path shuffling and backporting JDK-8295894. See #48
Testing:
jdk/test/security/infra/java/security/cert/CertPathValidatorandjdk/test/sun/security/lib/cacertsjtreg tests. All pass exceptAmazonCA.javawhich is a different matter (it'll be OK again once JDK-8309088 is in as well).Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u.git pull/49/head:pull/49$ git checkout pull/49Update a local copy of the PR:
$ git checkout pull/49$ git pull https://git.openjdk.org/jdk8u.git pull/49/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 49View PR using the GUI difftool:
$ git pr show -t 49Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u/pull/49.diff
Webrev
Link to Webrev Comment