-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8321408: Add Certainly roots R1 and E1 #54
Conversation
👋 Welcome back andrew! A progress list of the required criteria for merging this PR into |
@gnu-andrew This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
|
Yes. See openjdk/jdk8u-dev#471 for the problem listing. Those generate too much noise. |
Thanks Severin. |
@gnu-andrew |
/approve yes |
@jerboaa |
/integrate |
Going to push as commit 04ccdbf. |
@gnu-andrew Pushed as commit 04ccdbf. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Clean backport (with path shuffling) to add two new root certificates.
New tests fail before patching and succeed after:
The following failures are common to both runs:
which are believe are caused by /JDK-8324583 and unrelated to this change.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u.git pull/54/head:pull/54
$ git checkout pull/54
Update a local copy of the PR:
$ git checkout pull/54
$ git pull https://git.openjdk.org/jdk8u.git pull/54/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 54
View PR using the GUI difftool:
$ git pr show -t 54
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u/pull/54.diff
Webrev
Link to Webrev Comment