Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8321408: Add Certainly roots R1 and E1 #54

Closed
wants to merge 1 commit into from

Conversation

gnu-andrew
Copy link
Member

@gnu-andrew gnu-andrew commented Mar 22, 2024

Clean backport (with path shuffling) to add two new root certificates.

New tests fail before patching and succeed after:

-FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#certainlyroote1
-FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#certainlyrootr1
+Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#certainlyroote1
+Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#certainlyrootr1

The following failures are common to both runs:

FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigneccrootcar4
FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar1
FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar2
FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar3
FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar4

which are believe are caused by /JDK-8324583 and unrelated to this change.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8321408 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8321408: Add Certainly roots R1 and E1 (Enhancement - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u.git pull/54/head:pull/54
$ git checkout pull/54

Update a local copy of the PR:
$ git checkout pull/54
$ git pull https://git.openjdk.org/jdk8u.git pull/54/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 54

View PR using the GUI difftool:
$ git pr show -t 54

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u/pull/54.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 22, 2024

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 22, 2024

@gnu-andrew This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8321408: Add Certainly roots R1 and E1

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport e8f7eaeefe503a34089fd49051f9114d98a63cb1 8321408: Add Certainly roots R1 and E1 Mar 22, 2024
@openjdk
Copy link

openjdk bot commented Mar 22, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 22, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 22, 2024

Webrevs

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Mar 22, 2024

⚠️ @gnu-andrew This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@jerboaa
Copy link
Contributor

jerboaa commented Mar 22, 2024

The following failures are common to both runs:

FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigneccrootcar4
FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar1
FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar2
FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar3
FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar4

which are believe are caused by /JDK-8324583 and unrelated to this change.

Yes. See openjdk/jdk8u-dev#471 for the problem listing. Those generate too much noise.

@gnu-andrew
Copy link
Member Author

Thanks Severin.
/approval request Root certificate update with two new certificates. The same update is being made to later JDKs (11, 17, 21, 22) for April so it would be good to keep 8u in sync.

@openjdk
Copy link

openjdk bot commented Mar 22, 2024

@gnu-andrew
8321408: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Mar 22, 2024
@jerboaa
Copy link
Contributor

jerboaa commented Mar 22, 2024

/approve yes

@openjdk
Copy link

openjdk bot commented Mar 22, 2024

@jerboaa
8321408: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Mar 22, 2024
@gnu-andrew
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 22, 2024

Going to push as commit 04ccdbf.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 22, 2024
@openjdk openjdk bot closed this Mar 22, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 22, 2024
@openjdk
Copy link

openjdk bot commented Mar 22, 2024

@gnu-andrew Pushed as commit 04ccdbf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants