Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8331791: [8u] AIX build break from JDK-8320005 backport #55

Closed

Conversation

suchismith1993
Copy link

@suchismith1993 suchismith1993 commented May 7, 2024

c1c8064
introduces a new call to the macro FREE_C_HEAP_ARRAY
but is not using the correct number of arguments.
jdk8u FREE_C_HEAP_ARRAY takes 3 arguments
JBS-ISSUE: JDK-8331791


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8331791 needs maintainer approval

Issue

  • JDK-8331791: [8u] AIX build break from JDK-8320005 backport (Bug - P1)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u.git pull/55/head:pull/55
$ git checkout pull/55

Update a local copy of the PR:
$ git checkout pull/55
$ git pull https://git.openjdk.org/jdk8u.git pull/55/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 55

View PR using the GUI difftool:
$ git pr show -t 55

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u/pull/55.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 7, 2024

👋 Welcome back sroy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 7, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title JDK-8331791: [8u] AIX build break from JDK-8320005 backport 8331791: [8u] AIX build break from JDK-8320005 backport May 7, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label May 7, 2024
@mlbridge
Copy link

mlbridge bot commented May 7, 2024

Webrevs

@suchismith1993
Copy link
Author

@jerboaa I have pushed the fix. However i am not sure why this was not caught by the pre-submit tests before.

@jerboaa
Copy link
Contributor

jerboaa commented May 7, 2024

@jerboaa I have pushed the fix. However i am not sure why this was not caught by the pre-submit tests before.

GHA doesn't run AIX builds. You need to check those OS/arch combinations yourself.

@jerboaa
Copy link
Contributor

jerboaa commented May 7, 2024

This is the wrong repo. Please open the PR on jdk8u-dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants