Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8334441: Mark tests in jdk_security_infra group as manual #57

Closed
wants to merge 1 commit into from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Jun 25, 2024

Hi all,

This pull request contains a backport of commit 1e3e6877 from the openjdk/jdk11u repository.

The commit being backported was authored by SendaoYan on 25 Jun 2024 and was reviewed by Martin Doerr.

There are several files cause this backport not cleanly:

  1. test/jdk/TEST.groups not exists in jdk8u-dev, and it not need to backport.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8334441 needs maintainer approval

Issue

  • JDK-8334441: Mark tests in jdk_security_infra group as manual (Bug - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u.git pull/57/head:pull/57
$ git checkout pull/57

Update a local copy of the PR:
$ git checkout pull/57
$ git pull https://git.openjdk.org/jdk8u.git pull/57/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 57

View PR using the GUI difftool:
$ git pr show -t 57

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u/pull/57.diff

Webrev

Link to Webrev Comment

@sendaoYan
Copy link
Member Author

/approval request Backport JDK-8334441 to make some CA testcases as manual, no risk.

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 25, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 25, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 1e3e6877d5c2eb53f9dbb4fc9e045d83975c84b1 8334441: Mark tests in jdk_security_infra group as manual Jun 25, 2024
@openjdk
Copy link

openjdk bot commented Jun 25, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 25, 2024
@openjdk
Copy link

openjdk bot commented Jun 25, 2024

@sendaoYan
8334441: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jun 25, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 25, 2024

Webrevs

@jerboaa
Copy link
Contributor

jerboaa commented Jun 25, 2024

@sendaoYan The jdk8u tree is currently frozen. No more changes are going to be accepted. See:
https://mail.openjdk.org/pipermail/jdk8u-dev/2024-June/018738.html Please close this one. You have a pr on jdk8u-dev as well anyway.

@sendaoYan
Copy link
Member Author

@sendaoYan The jdk8u tree is currently frozen. No more changes are going to be accepted. See: https://mail.openjdk.org/pipermail/jdk8u-dev/2024-June/018738.html Please close this one. You have a pr on jdk8u-dev as well anyway.

Okey.

@sendaoYan sendaoYan closed this Jun 25, 2024
@sendaoYan sendaoYan deleted the jbs8334441 branch June 25, 2024 07:45
@gnu-andrew
Copy link
Member

@sendaoYan The jdk8u tree is currently frozen. No more changes are going to be accepted. See: https://mail.openjdk.org/pipermail/jdk8u-dev/2024-June/018738.html Please close this one. You have a pr on jdk8u-dev as well anyway.

I also don't see any reason why this would have been accepted during rampdown. I see nothing critical about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants