-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8334441: Mark tests in jdk_security_infra group as manual #57
Conversation
/approval request Backport JDK-8334441 to make some CA testcases as manual, no risk. |
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
@sendaoYan |
@sendaoYan The |
Okey. |
I also don't see any reason why this would have been accepted during rampdown. I see nothing critical about it. |
Hi all,
This pull request contains a backport of commit 1e3e6877 from the openjdk/jdk11u repository.
The commit being backported was authored by SendaoYan on 25 Jun 2024 and was reviewed by Martin Doerr.
There are several files cause this backport not cleanly:
test/jdk/TEST.groups
not exists injdk8u-dev
, and it not need to backport.Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u.git pull/57/head:pull/57
$ git checkout pull/57
Update a local copy of the PR:
$ git checkout pull/57
$ git pull https://git.openjdk.org/jdk8u.git pull/57/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 57
View PR using the GUI difftool:
$ git pr show -t 57
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u/pull/57.diff
Webrev
Link to Webrev Comment