Skip to content

Conversation

@jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Oct 1, 2024

This is a follow-up backport to JDK-8337664 which is in 8u432 (October). We should get this added as well so as to align with other releases this October (11, 17, 21).

The JDK 11 patch is not clean. Mostly because of the adaptations that were needed in EntrustTLSPolicy.java and porting to the many java.security-<os> files. The rest is path shuffeling.

The tests in jdk/test/sun/security/ssl/X509TrustManagerImpl/ pass:

Passed: sun/security/ssl/X509TrustManagerImpl/Entrust/Distrust.java
Passed: sun/security/ssl/X509TrustManagerImpl/Symantec/Distrust.java
Passed: sun/security/ssl/X509TrustManagerImpl/BasicConstraints.java
Passed: sun/security/ssl/X509TrustManagerImpl/CacertsLimit.java
Passed: sun/security/ssl/X509TrustManagerImpl/CertRequestOverflow.java
Passed: sun/security/ssl/X509TrustManagerImpl/CheckNullEntity.java
Passed: sun/security/ssl/X509TrustManagerImpl/ClientServer.java
Passed: sun/security/ssl/X509TrustManagerImpl/ComodoHacker.java
Passed: sun/security/ssl/X509TrustManagerImpl/PKIXExtendedTM.java
Passed: sun/security/ssl/X509TrustManagerImpl/SelfIssuedCert.java
Passed: sun/security/ssl/X509TrustManagerImpl/SunX509ExtendedTM.java
Passed: sun/security/ssl/X509TrustManagerImpl/TooManyCAs.java
Passed: sun/security/ssl/X509TrustManagerImpl/X509ExtendedTMEnabled.java
Test results: passed: 13

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8341059 needs maintainer approval
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8341087 to be approved

Issues

  • JDK-8341059: Change Entrust TLS distrust date to November 12, 2024 (Enhancement - P2)
  • JDK-8341087: Change Entrust TLS distrust date to November 12, 2024 (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u.git pull/62/head:pull/62
$ git checkout pull/62

Update a local copy of the PR:
$ git checkout pull/62
$ git pull https://git.openjdk.org/jdk8u.git pull/62/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 62

View PR using the GUI difftool:
$ git pr show -t 62

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u/pull/62.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 1, 2024

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 1, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport eced83e13090748218ab3dac78f6ff1bddf2b158 8341059: Change Entrust TLS distrust date to November 12, 2024 Oct 1, 2024
@openjdk
Copy link

openjdk bot commented Oct 1, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Oct 1, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 1, 2024

Webrevs

Copy link
Contributor

@martinuy martinuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. jdk/test/sun/security/ssl/X509TrustManagerImpl/Entrust/Distrust.java is passing.

@openjdk
Copy link

openjdk bot commented Oct 1, 2024

⚠️ @jerboaa This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@gnu-andrew
Copy link
Member

8u is CLOSED for commits after 2024-09-27.
Read the schedule: https://wiki.openjdk.org/display/jdk8u/Main

@gnu-andrew
Copy link
Member

Correct PR: openjdk/jdk8u-dev#588

@jerboaa jerboaa closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

3 participants