8342822: jdk8u432-b06 does not compile on AIX

[varada1110]

Build error on AIX could be resolved with the addition of header file which could be guarded with ifdef to make it aix-specific. Jtreg testing for hotspot/test on aix-ppc64 is successful with no related failures.

JBS : JDK-8342822

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8342822 needs maintainer approval

Issue

• JDK-8342822: jdk8u432-b06 does not compile on AIX (Bug - P2 - Approved)

Reviewers

• Andrew John Hughes (@gnu-andrew - Reviewer)
• Amit Kumar (@offamitkumar - no project role)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u.git pull/65/head:pull/65
$ git checkout pull/65

Update a local copy of the PR:
$ git checkout pull/65
$ git pull https://git.openjdk.org/jdk8u.git pull/65/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 65

View PR using the GUI difftool:
$ git pr show -t 65

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u/pull/65.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back varadam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@varada1110 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8342822: jdk8u432-b06 does not compile on AIX

Reviewed-by: andrew, amitkumar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[varada1110]

/approval 8342822 request build error observed on aix is resolved with the addition of cstdlib header file. Build and jtreg testing(hotspot/test) successful

[openjdk]

@varada1110
8342822: The approval request has been created successfully.

[mlbridge]

Webrevs

• 00: Full (e45539c7)

[gnu-andrew]

Already successfully reviewed on openjdk/jdk8u-dev#600 by myself, @franferrax & @sxa

[gnu-andrew]

/approve yes

[openjdk]

@gnu-andrew
8342822: The approval request has been approved.

[varada1110]

Thank you
/integrate

[openjdk]

@varada1110
Your change (at version e45539c) is now ready to be sponsored by a Committer.

[offamitkumar]

I do have committer rights for jdk-updates. Looks like jdk8u requires separate rights.

[gnu-andrew]

/sponsor

[openjdk]

Going to push as commit 1a6e3a5.

[openjdk]

@gnu-andrew @varada1110 Pushed as commit 1a6e3a5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[gnu-andrew]

I do have committer rights for jdk-updates. Looks like jdk8u requires separate rights.

Yes, jdk6u, jdk7u and jdk8u were all separate projects, before the consolidation under jdk-updates for more recent long term support releases.

[tstuefe]

+1

[sxa]

Thanks @gnu-andrew ... Will we get a jdk8u442-b05 tag with this change in before the GA in January? We haven't had any new 8u442 tags for a few weeks now.