-
Notifications
You must be signed in to change notification settings - Fork 208
8352097: (tz) zone.tab update missed in 2025a backport #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back andrew! A progress list of the required criteria for merging this PR into |
@gnu-andrew This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
|
Thanks Dmitry. /approval request Follow-up fix to the tzdata 2025a backport to include a change to a file no longer present in OpenJDK 25, but patched in OpenJDK 24. Tests on |
@gnu-andrew |
/approve yes |
@jerboaa |
/integrate |
Going to push as commit b10963f. |
@gnu-andrew Pushed as commit b10963f. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
As with openjdk/jdk21u#460, openjdk/jdk17u#405 & openjdk/jdk11u#101, the 8u backport of the tzdata 2025a update missed an update to zone.tab, as this was not present in the 25u commit on which it was originally based, due to its removal in JDK-8166983. The change was in the 24u commit which was applied later than the 21u one.
We should add this missing change to the existing 2025a update in 8u452 and consider backporting JDK-8166983 for 8u462 (now proposed for 24 in openjdk/jdk24u#150).
Patch from 11u applies cleanly to the
make/data
file when applied from thejdk
subdirectory (-p1
) and to the copy intest/sun/util/calendar/zi/tzdata
applied fromtest/sun/util/calendar/zi
subdirectory (-p3
) .Testing showed no regressions:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u.git pull/71/head:pull/71
$ git checkout pull/71
Update a local copy of the PR:
$ git checkout pull/71
$ git pull https://git.openjdk.org/jdk8u.git pull/71/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 71
View PR using the GUI difftool:
$ git pr show -t 71
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u/pull/71.diff
Using Webrev
Link to Webrev Comment