-
Notifications
You must be signed in to change notification settings - Fork 229
8368308: ISO 4217 Amendment 180 Update #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into |
|
@jerboaa This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
gnu-andrew
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolves were trivial
The only one I see is the manual application in ValidateISO4217.java of the new currency code because of the different indentation. This is due to 8u not having the refactoring in JDK-8310923 which would in turn require a new JTreg and the headaches that involves (it took a long time to go to 11u , IIRC). Were there any others?
|
|
No. But paths to files are different in 8u as well. |
|
Thanks for the quick review! |
|
/approval request Please allow this backport in for JDK 8u472 (October) since it includes currency updates which are going to be in effect before the next update in January 2026. Those amendment updates are usually low risk. The patch needed trivial resolves in ValidateISO4217.java other than path shuffeling. Currency tests pass and patch is reviewed by Andrew Hughes. |
Oh yeah, I tend to still count that as clean. The only ones to really worry about are new files. We've had the odd test sneak into the wrong tree (particularly with the big JFR change). If you've patched the same context in an existing file, then this should imply the paths have been shuffled correctly. |
|
/approve yes |
|
@gnu-andrew |
|
/integrate |
|
Going to push as commit 2e6cbc9. |
Not a clean backport to the JDK 11u version, but resolves were trivial. Changes to
jdk/test/java/util/Currency/ValidateISO4217.javawhere manually redone.Testing:
java/util/Currency/tests pass.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u.git pull/80/head:pull/80$ git checkout pull/80Update a local copy of the PR:
$ git checkout pull/80$ git pull https://git.openjdk.org/jdk8u.git pull/80/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 80View PR using the GUI difftool:
$ git pr show -t 80Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u/pull/80.diff
Using Webrev
Link to Webrev Comment