Codetools 7902736

[shurymury]

Add selected text to the dump, whether or not the test is empty. Add empty string for null return value.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Referenced JBS issue must only be used for a single change
• Change must be properly reviewed

Download

$ git fetch https://git.openjdk.java.net/jemmy-v2 pull/2/head:pull/2
$ git checkout pull/2

[bridgekeeper]

👋 Welcome back shurailine! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shurymury This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

Codetools 7902736

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 01: Full - Incremental (9d40d5c)
• 00: Full (9d40d5c)

[amresh-sahu]

Looks fine.

[akolarkunnu]

Just a thought - Is it a good idea to differentiate 'null' and empty string - May be by replacing "" with "null" when selectedText is null.
Also what about renaming 'selected' with 'selectedText' .

[shurymury]

On Nov 10, 2020, at 10:58 PM, Muneer Kolarkunnu ***@***.***> wrote: Just a thought - Is it a good idea to differentiate 'null' and empty string - May be by replacing "" with "null" when selectedText is null.

I thought about it. Null selection really means nothing is selected. Empty value is saying that. “null” could be misleading because “null” could actually be a selected text.

Also what about renaming 'selected' with 'selectedText' .

It’s a local var, renaming would not change any semantic or behavior or would not make code more or less easier to understood. Shura

…

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <https://urldefense.com/v3/__https://github.com/openjdk/jemmy-v2/pull/2*issuecomment-725241331__;Iw!!GqivPVa7Brio!Ji1C1MKf4VPGDLwtUa7jf7YzOS6RmeBkdPAfxSWP2RICon79hcHht6_8o84KZWxzm7Y$>, or unsubscribe <https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ABN6PZRS36B4BVF34NWHL3LSPIYZPANCNFSM4TRJPXOQ__;!!GqivPVa7Brio!Ji1C1MKf4VPGDLwtUa7jf7YzOS6RmeBkdPAfxSWP2RICon79hcHht6_8o84KsmQwc3w$>.

[akolarkunnu]

ok, fine