Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codetools 7902736 #2

Merged
merged 2 commits into from Nov 18, 2020
Merged

Codetools 7902736 #2

merged 2 commits into from Nov 18, 2020

Conversation

shurymury
Copy link
Collaborator

@shurymury shurymury commented Nov 10, 2020

Add selected text to the dump, whether or not the test is empty. Add empty string for null return value.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Referenced JBS issue must only be used for a single change
  • Change must be properly reviewed

Download

$ git fetch https://git.openjdk.java.net/jemmy-v2 pull/2/head:pull/2
$ git checkout pull/2

@shurymury shurymury requested a review from akolarkunnu Nov 10, 2020
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 10, 2020

👋 Welcome back shurailine! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 10, 2020

@shurymury This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

Codetools 7902736

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Nov 10, 2020
@mlbridge
Copy link

mlbridge bot commented Nov 10, 2020

Webrevs

Copy link

@amresh-sahu amresh-sahu left a comment

Looks fine.

@akolarkunnu
Copy link
Collaborator

akolarkunnu commented Nov 11, 2020

Just a thought - Is it a good idea to differentiate 'null' and empty string - May be by replacing "" with "null" when selectedText is null.
Also what about renaming 'selected' with 'selectedText' .

@shurymury
Copy link
Collaborator Author

shurymury commented Nov 12, 2020

@akolarkunnu
Copy link
Collaborator

akolarkunnu commented Nov 13, 2020

ok, fine

@shurymury shurymury merged commit 9d40d5c into openjdk:master Nov 18, 2020
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready rfr
3 participants