CODETOOLS-7902793: Fix IllegalMonitorStateException in JInternalFrameOperatorCloseTest #3
Conversation
|
|
|
please review @shurymury @akolarkunnu |
removed whitespaces.
Removed whitespace.
|
@amresh-sahu This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shurymury) but any other Committer may sponsor as well.
|
|
Please review @akolarkunnu @shurymury |
Webrevs
|
| } catch (InterruptedException e1) { | ||
| e1.printStackTrace(); | ||
| } | ||
| new QueueTool().waitEmpty(); |
There was a problem hiding this comment.
There is a comment below, which explains what should be here:
// Making not to close the fame for 1 minute and expecting TimeoutExpiredException
// from waitClosed()
Which would mean that the lines in internalFrameClosing(InternalFrameEvent e) should just delay the execution for minute. The reason for doing that, it looks like, is that there is no other way to detect window closing but by the timeout.
Your fix is doing something completely different.
There was a problem hiding this comment.
Removed negative test scenario.
Currently, Testing that Internal frame is closing or not.
There were two scenarios one is happy path scenario where only closing internal frame was being tested and another was negative scenario where TimeoutExpiredException was expected so removed the negative test scenario.
Removed whitespace and tabs.
Update forked branch
IllegalMonitorStateException has been fixed.
Progress
Issue
Download
$ git fetch https://git.openjdk.java.net/jemmy-v2 pull/3/head:pull/3$ git checkout pull/3