Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODETOOLS-7902811: Add accessible name and description to the dump #5

Merged
merged 2 commits into from Dec 16, 2020

Conversation

shurymury
Copy link
Collaborator

@shurymury shurymury commented Dec 16, 2020

Accessible name and description are useful to identify components in the hierarchy.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Referenced JBS issue must only be used for a single change
  • Change must be properly reviewed

Issue

Download

$ git fetch https://git.openjdk.java.net/jemmy-v2 pull/5/head:pull/5
$ git checkout pull/5

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 16, 2020

👋 Welcome back shurailine! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@shurymury shurymury requested a review from akolarkunnu Dec 16, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 16, 2020

@shurymury This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

7902811: Add accessible name and description to the dump

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Dec 16, 2020
@shurymury
Copy link
Collaborator Author

@shurymury shurymury commented Dec 16, 2020

@amresh-sahu?

@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 16, 2020

Webrevs

@amresh-sahu
Copy link

@amresh-sahu amresh-sahu commented Dec 16, 2020

LGTM.

@shurymury shurymury merged commit bc246f7 into openjdk:master Dec 16, 2020
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready rfr
2 participants