Skip to content

Conversation

@sundararajana
Copy link
Member

@sundararajana sundararajana commented Dec 5, 2022

Synching jextract with jdk 20 Panama API changes JEP 434: Foreign Function & Memory API (Second Preview)


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed (no review required)

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jextract pull/94/head:pull/94
$ git checkout pull/94

Update a local copy of the PR:
$ git checkout pull/94
$ git pull https://git.openjdk.org/jextract pull/94/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 94

View PR using the GUI difftool:
$ git pr show -t 94

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jextract/pull/94.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 5, 2022

👋 Welcome back sundar! A progress list of the required criteria for merging this PR into panama will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 5, 2022

@sundararajana This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

7903384: sync jextract for jdk 20 panama API changes

Reviewed-by: mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jdk20 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk20 branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 5, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 5, 2022

Webrevs

Copy link
Contributor

@mcimadamore mcimadamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - as discussed offline, we probably need to update everything to use --release 21, as that's what the panama repo requires.

@sundararajana sundararajana changed the base branch from panama to jdk20 December 12, 2022 13:02
@sundararajana
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 12, 2022

Going to push as commit 23c6ff7.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 12, 2022
@openjdk openjdk bot closed this Dec 12, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 12, 2022
@openjdk
Copy link

openjdk bot commented Dec 12, 2022

@sundararajana Pushed as commit 23c6ff7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sundararajana sundararajana deleted the CODETOOLS-7903384 branch December 12, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants