Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316490: Problemlist ParallelCamera picking tests #12

Closed
wants to merge 1 commit into from

Conversation

jayathirthrao
Copy link
Member

@jayathirthrao jayathirthrao commented Sep 22, 2023

When we run 3D picking tests under test/scenegraph/fx3d/picking/parallel/ nothing is displayed on the window and subscene parallel camera tests under test/scenegraph/fx3d/subscene/picking/parallel/ throw UnsupportedOperationException.

Subscene parallel camera tests are incomplete and even if we update the tests nothing will be shown because of product issue https://bugs.openjdk.org/browse/JDK-8165941.

ParallelCamera forces near and far clip to be between -viewWidthOrHeight/2 and viewWidthOrHeight/2. So in these test cases we generate a mesh and then scale it 100x. After that we move camera to large -z position to make content visible. This causes content to move into clipping area in case of ParallelCamera. Until https://bugs.openjdk.org/browse/JDK-8165941 is fixed we should problemlist these tests.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8316490: Problemlist ParallelCamera picking tests (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx-tests.git pull/12/head:pull/12
$ git checkout pull/12

Update a local copy of the PR:
$ git checkout pull/12
$ git pull https://git.openjdk.org/jfx-tests.git pull/12/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12

View PR using the GUI difftool:
$ git pr show -t 12

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx-tests/pull/12.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 22, 2023

👋 Welcome back jdv! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 22, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 22, 2023

Webrevs

Copy link
Contributor

@aghaisas aghaisas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@openjdk
Copy link

openjdk bot commented Sep 25, 2023

@jayathirthrao This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8316490: Problemlist ParallelCamera picking tests

Reviewed-by: aghaisas

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 49b6f8a: 8197397: Document steps for setting up and executing manual/automated tests in jfx-tests repo
  • 46f2827: 8316097: Some Scenegraph/richtext tests fail due to IllegalStateException
  • 3562363: 8315845: Exclude Scenegraph and Charts test classes that serve as a base class

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aghaisas) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 25, 2023
@jayathirthrao
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 25, 2023
@openjdk
Copy link

openjdk bot commented Sep 25, 2023

@jayathirthrao
Your change (at version b2efb32) is now ready to be sponsored by a Committer.

@aghaisas
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 25, 2023

Going to push as commit 5fc5fb5.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 49b6f8a: 8197397: Document steps for setting up and executing manual/automated tests in jfx-tests repo
  • 46f2827: 8316097: Some Scenegraph/richtext tests fail due to IllegalStateException
  • 3562363: 8315845: Exclude Scenegraph and Charts test classes that serve as a base class

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 25, 2023
@openjdk openjdk bot closed this Sep 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 25, 2023
@openjdk
Copy link

openjdk bot commented Sep 25, 2023

@aghaisas @jayathirthrao Pushed as commit 5fc5fb5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants