Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319231: Unrecognized "minimum" key in .jcheck/conf causes /reviewers command to be ignored #14

Closed
wants to merge 1 commit into from

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Nov 1, 2023

Fix the [checks "reviewers"] section of .jcheck/conf to match the mainline jfx repo. See openjdk/jfx#1275 for details.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8319231: Unrecognized "minimum" key in .jcheck/conf causes /reviewers command to be ignored (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx-tests.git pull/14/head:pull/14
$ git checkout pull/14

Update a local copy of the PR:
$ git checkout pull/14
$ git pull https://git.openjdk.org/jfx-tests.git pull/14/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14

View PR using the GUI difftool:
$ git pr show -t 14

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx-tests/pull/14.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 1, 2023

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 1, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 1, 2023

Webrevs

@kevinrushforth
Copy link
Member Author

@andy-goryachev-oracle Can you Review the jcheck fix for this repo, too?

@kevinrushforth
Copy link
Member Author

The .jcheck/conf file in this repo is identical to the one in the jfx repo (after the identical fix is applied).

Copy link

@andy-goryachev-oracle andy-goryachev-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openjdk
Copy link

openjdk bot commented Nov 1, 2023

@kevinrushforth This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8319231: Unrecognized "minimum" key in .jcheck/conf causes /reviewers command to be ignored

Reviewed-by: angorya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 780824d: 8316807: Exclude 3D subscene perspective camera picking tests
  • 5fc5fb5: 8316490: Problemlist ParallelCamera picking tests
  • 49b6f8a: 8197397: Document steps for setting up and executing manual/automated tests in jfx-tests repo
  • 46f2827: 8316097: Some Scenegraph/richtext tests fail due to IllegalStateException
  • 3562363: 8315845: Exclude Scenegraph and Charts test classes that serve as a base class
  • f1bed10: 8315928: Few Scenegraph and Charts tests fail due to resource not found error
  • 082013f: 8316116: Ignore a single failing test case from Effects2Test
  • ba883a2: 8315895: Some 3D camera tests fail because of NPE
  • 0d35c19: 8315842: 3D tests fail because of edge pixel differences
  • 93ae939: 8315809: Fix copyright lines in jfx-tests repo after JDK-8315409
  • ... and 1 more: https://git.openjdk.org/jfx-tests/compare/9a7df0b57cb8ce035b3221a24a20d62d049c7090...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 1, 2023
@kevinrushforth
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 1, 2023

Going to push as commit 5c61910.
Since your change was applied there have been 11 commits pushed to the master branch:

  • 780824d: 8316807: Exclude 3D subscene perspective camera picking tests
  • 5fc5fb5: 8316490: Problemlist ParallelCamera picking tests
  • 49b6f8a: 8197397: Document steps for setting up and executing manual/automated tests in jfx-tests repo
  • 46f2827: 8316097: Some Scenegraph/richtext tests fail due to IllegalStateException
  • 3562363: 8315845: Exclude Scenegraph and Charts test classes that serve as a base class
  • f1bed10: 8315928: Few Scenegraph and Charts tests fail due to resource not found error
  • 082013f: 8316116: Ignore a single failing test case from Effects2Test
  • ba883a2: 8315895: Some 3D camera tests fail because of NPE
  • 0d35c19: 8315842: 3D tests fail because of edge pixel differences
  • 93ae939: 8315809: Fix copyright lines in jfx-tests repo after JDK-8315409
  • ... and 1 more: https://git.openjdk.org/jfx-tests/compare/9a7df0b57cb8ce035b3221a24a20d62d049c7090...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 1, 2023
@openjdk openjdk bot closed this Nov 1, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 1, 2023
@openjdk
Copy link

openjdk bot commented Nov 1, 2023

@kevinrushforth Pushed as commit 5c61910.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth kevinrushforth deleted the 8319231-jcheck branch November 1, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants