Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315845: Exclude Scenegraph and Charts test classes that serve as a base class #4

Closed

Conversation

aghaisas
Copy link
Contributor

@aghaisas aghaisas commented Sep 7, 2023

A few SceneGraphTests and ControlsTests/chart test classes are abstract classes and serve as base classes for other tests.
They are excluded from test execution and hence result in avoiding false failure reports.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8315845: Exclude Scenegraph and Charts test classes that serve as a base class (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx-tests.git pull/4/head:pull/4
$ git checkout pull/4

Update a local copy of the PR:
$ git checkout pull/4
$ git pull https://git.openjdk.org/jfx-tests.git pull/4/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4

View PR using the GUI difftool:
$ git pr show -t 4

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx-tests/pull/4.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 7, 2023

👋 Welcome back aghaisas! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 7, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 7, 2023

Webrevs

Copy link
Member

@jayathirthrao jayathirthrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I think in 3D tests also we have similar problem.
When i run sub-folders it runs some files which i think should not be run in standlone mode and they throw java.lang.InstantiationException

@aghaisas
Copy link
Contributor Author

aghaisas commented Sep 8, 2023

Please collate such file names and then we can exclude them as a separate fix.

@openjdk
Copy link

openjdk bot commented Sep 14, 2023

@aghaisas This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8315845: Exclude Scenegraph and Charts test classes that serve as a base class

Reviewed-by: jdv, arapte

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • f1bed10: 8315928: Few Scenegraph and Charts tests fail due to resource not found error
  • 082013f: 8316116: Ignore a single failing test case from Effects2Test
  • ba883a2: 8315895: Some 3D camera tests fail because of NPE
  • 0d35c19: 8315842: 3D tests fail because of edge pixel differences
  • 93ae939: 8315809: Fix copyright lines in jfx-tests repo after JDK-8315409
  • 30c2529: 8315839: 3D shape tests fail because of invalid file path

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 14, 2023
@aghaisas
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 14, 2023

Going to push as commit 3562363.
Since your change was applied there have been 6 commits pushed to the master branch:

  • f1bed10: 8315928: Few Scenegraph and Charts tests fail due to resource not found error
  • 082013f: 8316116: Ignore a single failing test case from Effects2Test
  • ba883a2: 8315895: Some 3D camera tests fail because of NPE
  • 0d35c19: 8315842: 3D tests fail because of edge pixel differences
  • 93ae939: 8315809: Fix copyright lines in jfx-tests repo after JDK-8315409
  • 30c2529: 8315839: 3D shape tests fail because of invalid file path

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 14, 2023
@openjdk openjdk bot closed this Sep 14, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 14, 2023
@openjdk
Copy link

openjdk bot commented Sep 14, 2023

@aghaisas Pushed as commit 3562363.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
3 participants