8301797: Pagination control has the wrong size

Reviewed-by: kcr, aghaisas

modules/javafx.controls/src/main/java/javafx/scene/control/skin/PaginationSkin.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2012, 2022, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2012, 2023, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -194,6 +194,9 @@ public PaginationSkin(final Pagination control) {
         nextStackPane.getStyleClass().add("page");
         nextStackPane.setVisible(false);
 
+        // sets the current page index property in control to the same value (no-op)
+        resetIndexes(true);
+
         this.navigation = new NavigationControl();
 
         getChildren().addAll(currentStackPane, nextStackPane, navigation);
@@ -235,7 +238,6 @@ public PaginationSkin(final Pagination control) {
     @Override
     public void install() {
         getSkinnable().setClip(clipRect);
-        resetIndexes(true);
     }
 
 

modules/javafx.controls/src/test/java/test/javafx/scene/control/PaginationTest.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2010, 2022, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2010, 2023, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -324,4 +324,23 @@ public VBox createPage(int pageIndex) {
         }
         return box;
     }
+
+    /** JDK-8301797 */
+    @Test
+    public void testInitialPreferredSize() {
+        pagination.setPageCount(150);
+        pagination.setCurrentPageIndex(0);
+        pagination.setMaxPageIndicatorCount(50);
+        Label label = new Label();
+        pagination.setPageFactory(index -> {
+            label.setText("" + (index + 1));
+            return label;
+        });
+
+        root.getChildren().add(pagination);
+        show();
+
+        tk.firePulse();
+        assertTrue("pagination prefWidth() is incorrect", (pagination.prefWidth(-1) > 200));
+    }
 }