8357714: AudioClip.play crash on macOS when loading resource from jar

Reviewed-by: angorya, almatvee

Author: Johan Vos

modules/javafx.media/src/main/native/jfxmedia/platform/osx/OSXMediaPlayer.mm

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2010, 2022, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2010, 2025, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -327,15 +327,17 @@ - (void) stop
     if ([scheme caseInsensitiveCompare:@"jar"] == NSOrderedSame ||
         [scheme caseInsensitiveCompare:@"jrt"] == NSOrderedSame) {
         CJavaInputStreamCallbacks *callbacks = new (nothrow) CJavaInputStreamCallbacks();
-        if (callbacks == NULL) {
+        jobject jConnectionHolder = CLocator::CreateConnectionHolder(env, jLocator);
+        if (callbacks == NULL || jConnectionHolder == NULL) {
+            if (callbacks) delete callbacks;
             [mediaURL release];
             LOGGER_WARNMSG("OSXMediaPlayer: Unable to create CJavaInputStreamCallbacks\n");
             ThrowJavaException(env, "com/sun/media/jfxmedia/MediaException",
                                "OSXMediaPlayer: Unable to create CJavaInputStreamCallbacks");
             return;
         }
 
-        if (!callbacks->Init(env, jLocator)) {
+        if (!callbacks->Init(env, jConnectionHolder)) {
             [mediaURL release];
             delete callbacks;
             LOGGER_WARNMSG("OSXMediaPlayer: callbacks->Init() failed\n");

modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFMediaPlayer.mm

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2014, 2024, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2014, 2025, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -780,10 +780,6 @@ - (BOOL)resourceLoader:(AVAssetResourceLoader *)resourceLoader
     }
 
     if (dataRequest != nil) {
-        long position = locatorStream->GetCallbacks()->Seek(dataRequest.requestedOffset);
-        if (position != dataRequest.requestedOffset) {
-            return NO;
-        }
 
         // If requestsAllDataToEndOfResource is YES, than requestedLength is
         // invalid and we need to provide all data to the end of file.
@@ -803,8 +799,23 @@ - (BOOL)resourceLoader:(AVAssetResourceLoader *)resourceLoader
         }
 
         NSMutableData* readData = nil;
+        bool isRandomAccess = locatorStream->GetCallbacks()->IsRandomAccess();
+        int64_t position = -1;
+        if (isRandomAccess) {
+            position = dataRequest.requestedOffset;
+        } else {
+            position = locatorStream->GetCallbacks()->Seek(dataRequest.requestedOffset);
+            if (position != dataRequest.requestedOffset) {
+                return NO;
+            }
+        }
         while (requestedLength > 0) {
-            unsigned int blockSize = locatorStream->GetCallbacks()->ReadNextBlock();
+            unsigned int blockSize = -1;
+            if (isRandomAccess) {
+                blockSize = locatorStream->GetCallbacks()->ReadBlock(position, requestedLength);
+            } else {
+                blockSize = locatorStream->GetCallbacks()->ReadNextBlock();
+            }
             if (blockSize <= 0) {
                 break;
             }
@@ -818,6 +829,7 @@ - (BOOL)resourceLoader:(AVAssetResourceLoader *)resourceLoader
             [loadingRequest.dataRequest respondWithData:readData];
 
             requestedLength -= readSize;
+            position += readSize;
         }
 
         [loadingRequest finishLoading];