8348100: Tooltips cannot be instantiated on background thread

Reviewed-by: kcr, mstrauss

Author: Andy Goryachev

modules/javafx.controls/src/main/java/javafx/scene/control/Tooltip.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2010, 2024, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2010, 2025, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -25,50 +25,53 @@
 
 package javafx.scene.control;
 
-import com.sun.javafx.beans.IDProperty;
-import com.sun.javafx.css.StyleManager;
-import com.sun.javafx.scene.NodeHelper;
-import com.sun.javafx.stage.PopupWindowHelper;
-
-import javafx.css.SimpleStyleableBooleanProperty;
-import javafx.css.SimpleStyleableDoubleProperty;
-import javafx.css.SimpleStyleableObjectProperty;
-import javafx.css.StyleOrigin;
-import javafx.css.StyleableObjectProperty;
-import javafx.css.StyleableStringProperty;
-
-import javafx.css.converter.BooleanConverter;
-import javafx.css.converter.EnumConverter;
-import javafx.css.converter.SizeConverter;
-import javafx.css.converter.StringConverter;
-import javafx.css.converter.DurationConverter;
-import javafx.scene.control.skin.TooltipSkin;
-
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.List;
-
 import javafx.animation.KeyFrame;
 import javafx.animation.Timeline;
-import javafx.beans.property.*;
+import javafx.application.Platform;
+import javafx.beans.property.BooleanProperty;
+import javafx.beans.property.DoubleProperty;
+import javafx.beans.property.ObjectProperty;
+import javafx.beans.property.ReadOnlyBooleanProperty;
+import javafx.beans.property.ReadOnlyBooleanWrapper;
+import javafx.beans.property.SimpleStringProperty;
+import javafx.beans.property.StringProperty;
 import javafx.beans.value.WritableValue;
 import javafx.css.CssMetaData;
 import javafx.css.FontCssMetaData;
+import javafx.css.SimpleStyleableBooleanProperty;
+import javafx.css.SimpleStyleableDoubleProperty;
+import javafx.css.SimpleStyleableObjectProperty;
+import javafx.css.StyleOrigin;
 import javafx.css.Styleable;
+import javafx.css.StyleableObjectProperty;
 import javafx.css.StyleableProperty;
+import javafx.css.StyleableStringProperty;
+import javafx.css.converter.BooleanConverter;
+import javafx.css.converter.DurationConverter;
+import javafx.css.converter.EnumConverter;
+import javafx.css.converter.SizeConverter;
+import javafx.css.converter.StringConverter;
 import javafx.event.EventHandler;
 import javafx.geometry.NodeOrientation;
 import javafx.scene.AccessibleRole;
 import javafx.scene.Node;
 import javafx.scene.Parent;
 import javafx.scene.Scene;
+import javafx.scene.control.skin.TooltipSkin;
 import javafx.scene.image.Image;
 import javafx.scene.image.ImageView;
 import javafx.scene.input.MouseEvent;
 import javafx.scene.text.Font;
 import javafx.scene.text.TextAlignment;
 import javafx.stage.Window;
 import javafx.util.Duration;
+import com.sun.javafx.beans.IDProperty;
+import com.sun.javafx.css.StyleManager;
+import com.sun.javafx.scene.NodeHelper;
+import com.sun.javafx.stage.PopupWindowHelper;
 
 /**
  * Tooltips are common UI elements which are typically used for showing
@@ -769,8 +772,9 @@ public StyleableProperty<Duration> getStyleableProperty(Tooltip.CSSBridge cssBri
         return getClassCssMetaData();
     }
 
-    @Override public Styleable getStyleableParent() {
-        if (BEHAVIOR.hoveredNode == null) {
+    @Override
+    public Styleable getStyleableParent() {
+        if (!Platform.isFxApplicationThread() || (BEHAVIOR.hoveredNode == null)) {
             return super.getStyleableParent();
         }
         return BEHAVIOR.hoveredNode;

tests/system/src/test/java/test/robot/javafx/scene/NodeInitializationStressTest.java

@@ -37,7 +37,9 @@
 import java.util.concurrent.atomic.AtomicReference;
 import java.util.function.Consumer;
 import java.util.function.Supplier;
+import javafx.application.Platform;
 import javafx.beans.property.SimpleObjectProperty;
+import javafx.geometry.Point2D;
 import javafx.geometry.Pos;
 import javafx.geometry.Side;
 import javafx.scene.Node;
@@ -87,6 +89,7 @@
 import javafx.scene.control.TitledPane;
 import javafx.scene.control.ToggleButton;
 import javafx.scene.control.ToolBar;
+import javafx.scene.control.Tooltip;
 import javafx.scene.control.TreeItem;
 import javafx.scene.control.TreeTableColumn;
 import javafx.scene.control.TreeTableView;
@@ -116,11 +119,14 @@
 import javafx.scene.control.skin.ToolBarSkin;
 import javafx.scene.control.skin.TreeTableViewSkin;
 import javafx.scene.control.skin.TreeViewSkin;
+import javafx.scene.layout.Border;
 import javafx.scene.layout.BorderPane;
 import javafx.scene.layout.Region;
+import javafx.scene.layout.VBox;
 import javafx.scene.paint.Color;
 import javafx.scene.text.Text;
 import javafx.scene.text.TextFlow;
+import javafx.util.Duration;
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.BeforeEach;
@@ -669,11 +675,46 @@ public void toolBar() {
         });
     }
 
-    @Disabled("JDK-8348100") // FIX
     @Test
     public void tooltip() {
         assumeFalse(SKIP_TEST);
-        // TODO will have a better test in JDK-8348100
+        AtomicBoolean phase = new AtomicBoolean();
+        test(() -> {
+            Tooltip t = new Tooltip("tooltip");
+            t.setStyle("-fx-background-color:red; -fx-min-width:100px; -fx-min-height:100px; -fx-wrap-text:true; -fx-show-delay:0ms; -fx-hide-delay:0ms;");
+            t.setShowDelay(Duration.ZERO);
+            t.setHideDelay(Duration.ZERO);
+            Label c = new Label("Tooltip");
+            c.setSkin(new LabelSkin(c));
+            c.setTooltip(t);
+            c.setBorder(Border.stroke(Color.BLACK));
+            c.setPrefHeight(500);
+            c.setPrefWidth(500);
+            VBox b = new VBox();
+            b.getChildren().add(c);
+            b.setId("Tooltip");
+            return b;
+        }, (c) -> {
+            Tooltip t = new Tooltip();
+            if (Platform.isFxApplicationThread()) {
+                Label label = (Label)c.getChildren().get(0);
+                Point2D p;
+                if (phase.get()) {
+                    p = c.localToScreen(c.getWidth() / 2.0, c.getHeight() / 2.0);
+                } else {
+                    p = c.localToScreen(c.getWidth() + 2, c.getHeight() + 2);
+                }
+                robot.mouseMove(p);
+                double h = STAGE_HEIGHT;
+                if (phase.get()) {
+                    h += 10;
+                }
+                label.setMinHeight(h);
+                label.setMaxHeight(h);
+                stage.setHeight(h);
+                phase.set(!phase.get());
+            }
+        });
     }
 
     @Test