Skip to content

Commit

Permalink
8328752: Fix missing @OVERRIDES in javafx.web
Browse files Browse the repository at this point in the history 
Reviewed-by: kcr, hmeda
  • Loading branch information
Andy Goryachev committed Apr 3, 2024
1 parent c41b000 commit 483c640
Show file tree
Hide file tree
Showing 103 changed files with 1,058 additions and 102 deletions.
9 changes: 8 additions & 1 deletion ...b/src/main/native/Source/WebCore/bindings/java/dom3/java/com/sun/webkit/dom/AttrImpl.java
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2013, 2017, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2013, 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -41,38 +41,45 @@ static Attr getImpl(long peer) {


// Attributes
@Override
public String getName() {
return getNameImpl(getPeer());
}
native static String getNameImpl(long peer);

@Override
public boolean getSpecified() {
return getSpecifiedImpl(getPeer());
}
native static boolean getSpecifiedImpl(long peer);

@Override
public String getValue() {
return getValueImpl(getPeer());
}
native static String getValueImpl(long peer);

@Override
public void setValue(String value) throws DOMException {
setValueImpl(getPeer(), value);
}
native static void setValueImpl(long peer, String value);

@Override
public Element getOwnerElement() {
return ElementImpl.getImpl(getOwnerElementImpl(getPeer()));
}
native static long getOwnerElementImpl(long peer);

@Override
public boolean isId() {
return isIdImpl(getPeer());
}
native static boolean isIdImpl(long peer);


//stubs
@Override
public TypeInfo getSchemaTypeInfo() {
throw new UnsupportedOperationException("Not supported yet.");
}
Expand Down
4 changes: 3 additions & 1 deletion .../native/Source/WebCore/bindings/java/dom3/java/com/sun/webkit/dom/CSSCharsetRuleImpl.java
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2013, 2017, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2013, 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -39,11 +39,13 @@ static CSSCharsetRule getImpl(long peer) {


// Attributes
@Override
public String getEncoding() {
return getEncodingImpl(getPeer());
}
native static String getEncodingImpl(long peer);

@Override
public void setEncoding(String value) throws DOMException {
setEncodingImpl(getPeer(), value);
}
Expand Down
3 changes: 2 additions & 1 deletion ...native/Source/WebCore/bindings/java/dom3/java/com/sun/webkit/dom/CSSFontFaceRuleImpl.java
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2013, 2017, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2013, 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -39,6 +39,7 @@ static CSSFontFaceRule getImpl(long peer) {


// Attributes
@Override
public CSSStyleDeclaration getStyle() {
return CSSStyleDeclarationImpl.getImpl(getStyleImpl(getPeer()));
}
Expand Down
5 changes: 4 additions & 1 deletion ...n/native/Source/WebCore/bindings/java/dom3/java/com/sun/webkit/dom/CSSImportRuleImpl.java
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2013, 2017, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2013, 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -40,16 +40,19 @@ static CSSImportRule getImpl(long peer) {


// Attributes
@Override
public String getHref() {
return getHrefImpl(getPeer());
}
native static String getHrefImpl(long peer);

@Override
public MediaList getMedia() {
return MediaListImpl.getImpl(getMediaImpl(getPeer()));
}
native static long getMediaImpl(long peer);

@Override
public CSSStyleSheet getStyleSheet() {
return CSSStyleSheetImpl.getImpl(getStyleSheetImpl(getPeer()));
}
Expand Down
6 changes: 5 additions & 1 deletion ...in/native/Source/WebCore/bindings/java/dom3/java/com/sun/webkit/dom/CSSMediaRuleImpl.java
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2013, 2017, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2013, 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -41,18 +41,21 @@ static CSSMediaRule getImpl(long peer) {


// Attributes
@Override
public MediaList getMedia() {
return MediaListImpl.getImpl(getMediaImpl(getPeer()));
}
native static long getMediaImpl(long peer);

@Override
public CSSRuleList getCssRules() {
return CSSRuleListImpl.getImpl(getCssRulesImpl(getPeer()));
}
native static long getCssRulesImpl(long peer);


// Functions
@Override
public int insertRule(String rule
, int index) throws DOMException
{
Expand All @@ -65,6 +68,7 @@ native static int insertRuleImpl(long peer
, int index);


@Override
public void deleteRule(int index) throws DOMException
{
deleteRuleImpl(getPeer()
Expand Down
5 changes: 4 additions & 1 deletion ...ain/native/Source/WebCore/bindings/java/dom3/java/com/sun/webkit/dom/CSSPageRuleImpl.java
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2013, 2017, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2013, 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -39,16 +39,19 @@ static CSSPageRule getImpl(long peer) {


// Attributes
@Override
public String getSelectorText() {
return getSelectorTextImpl(getPeer());
}
native static String getSelectorTextImpl(long peer);

@Override
public void setSelectorText(String value) {
setSelectorTextImpl(getPeer(), value);
}
native static void setSelectorTextImpl(long peer, String value);

@Override
public CSSStyleDeclaration getStyle() {
return CSSStyleDeclarationImpl.getImpl(getStyleImpl(getPeer()));
}
Expand Down
10 changes: 9 additions & 1 deletion ...tive/Source/WebCore/bindings/java/dom3/java/com/sun/webkit/dom/CSSPrimitiveValueImpl.java
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2013, 2017, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2013, 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -74,13 +74,15 @@ static CSSPrimitiveValue getImpl(long peer) {
public static final int CSS_VMAX = 29;

// Attributes
@Override
public short getPrimitiveType() {
return getPrimitiveTypeImpl(getPeer());
}
native static short getPrimitiveTypeImpl(long peer);


// Functions
@Override
public void setFloatValue(short unitType
, float floatValue) throws DOMException
{
Expand All @@ -93,6 +95,7 @@ native static void setFloatValueImpl(long peer
, float floatValue);


@Override
public float getFloatValue(short unitType) throws DOMException
{
return getFloatValueImpl(getPeer()
Expand All @@ -102,6 +105,7 @@ native static float getFloatValueImpl(long peer
, short unitType);


@Override
public void setStringValue(short stringType
, String stringValue) throws DOMException
{
Expand All @@ -114,27 +118,31 @@ native static void setStringValueImpl(long peer
, String stringValue);


@Override
public String getStringValue() throws DOMException
{
return getStringValueImpl(getPeer());
}
native static String getStringValueImpl(long peer);


@Override
public Counter getCounterValue() throws DOMException
{
return CounterImpl.getImpl(getCounterValueImpl(getPeer()));
}
native static long getCounterValueImpl(long peer);


@Override
public Rect getRectValue() throws DOMException
{
return RectImpl.getImpl(getRectValueImpl(getPeer()));
}
native static long getRectValueImpl(long peer);


@Override
public RGBColor getRGBColorValue() throws DOMException
{
return RGBColorImpl.getImpl(getRGBColorValueImpl(getPeer()));
Expand Down
9 changes: 8 additions & 1 deletion ...rc/main/native/Source/WebCore/bindings/java/dom3/java/com/sun/webkit/dom/CSSRuleImpl.java
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2013, 2017, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2013, 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -37,6 +37,8 @@ private static class SelfDisposer implements DisposerRecord {
SelfDisposer(final long peer) {
this.peer = peer;
}

@Override
public void dispose() {
CSSRuleImpl.dispose(peer);
}
Expand Down Expand Up @@ -102,26 +104,31 @@ static CSSRule getImpl(long peer) {
public static final int WEBKIT_KEYFRAME_RULE = 8;

// Attributes
@Override
public short getType() {
return getTypeImpl(getPeer());
}
native static short getTypeImpl(long peer);

@Override
public String getCssText() {
return getCssTextImpl(getPeer());
}
native static String getCssTextImpl(long peer);

@Override
public void setCssText(String value) throws DOMException {
setCssTextImpl(getPeer(), value);
}
native static void setCssTextImpl(long peer, String value);

@Override
public CSSStyleSheet getParentStyleSheet() {
return CSSStyleSheetImpl.getImpl(getParentStyleSheetImpl(getPeer()));
}
native static long getParentStyleSheetImpl(long peer);

@Override
public CSSRule getParentRule() {
return CSSRuleImpl.getImpl(getParentRuleImpl(getPeer()));
}
Expand Down
6 changes: 5 additions & 1 deletion ...ain/native/Source/WebCore/bindings/java/dom3/java/com/sun/webkit/dom/CSSRuleListImpl.java
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2013, 2017, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2013, 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -36,6 +36,8 @@ private static class SelfDisposer implements DisposerRecord {
SelfDisposer(final long peer) {
this.peer = peer;
}

@Override
public void dispose() {
CSSRuleListImpl.dispose(peer);
}
Expand Down Expand Up @@ -78,13 +80,15 @@ static CSSRuleList getImpl(long peer) {


// Attributes
@Override
public int getLength() {
return getLengthImpl(getPeer());
}
native static int getLengthImpl(long peer);


// Functions
@Override
public CSSRule item(int index)
{
return CSSRuleImpl.getImpl(itemImpl(getPeer()
Expand Down
Loading

3 comments on commit 483c640

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

@andy-goryachev-oracle
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jfx22u

@openjdk
Copy link

@openjdk openjdk bot commented on 483c640 Apr 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andy-goryachev-oracle the backport was successfully created on the branch backport-andy-goryachev-oracle-483c6408 in my personal fork of openjdk/jfx22u. To create a pull request with this backport targeting openjdk/jfx22u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 483c6408 from the openjdk/jfx repository.

The commit being backported was authored by Andy Goryachev on 3 Apr 2024 and was reviewed by Kevin Rushforth and Hima Bindu Meda.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jfx22u:

$ git fetch https://github.com/openjdk-bots/jfx22u.git backport-andy-goryachev-oracle-483c6408:backport-andy-goryachev-oracle-483c6408
$ git checkout backport-andy-goryachev-oracle-483c6408
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jfx22u.git backport-andy-goryachev-oracle-483c6408

Please sign in to comment.