Skip to content

Commit

Permalink
8338886: JavaFX debug builds fail on macOS
Browse files Browse the repository at this point in the history 
Reviewed-by: kcr
  • Loading branch information
Jay Bhaskar committed Aug 23, 2024
1 parent aa52f7e commit 4849716
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion modules/javafx.web/src/main/native/Source/WebCore/bindings/java/JavaDOMUtils.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ namespace WebCore {

static void raiseDOMErrorException(JNIEnv* env, WebCore::ExceptionCode ec)
{
ASSERT(ec);
ASSERT(ec == ExceptionCode::TypeError);

auto description = DOMException::description(ec);

Expand Down

3 comments on commit 4849716

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

@jaybhaskar
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jfx23u

@openjdk
Copy link

@openjdk openjdk bot commented on 4849716 Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaybhaskar the backport was successfully created on the branch backport-jaybhaskar-48497168-master in my personal fork of openjdk/jfx23u. To create a pull request with this backport targeting openjdk/jfx23u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 48497168 from the openjdk/jfx repository.

The commit being backported was authored by Jay Bhaskar on 23 Aug 2024 and was reviewed by Kevin Rushforth.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jfx23u:

$ git fetch https://github.com/openjdk-bots/jfx23u.git backport-jaybhaskar-48497168-master:backport-jaybhaskar-48497168-master
$ git checkout backport-jaybhaskar-48497168-master
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jfx23u.git backport-jaybhaskar-48497168-master

Please sign in to comment.