Skip to content
Permalink
Browse files
8273969: Memory Leak on the Runnable provided to Platform.startup
Reviewed-by: kcr
  • Loading branch information
FlorianKirmaier authored and kevinrushforth committed Sep 23, 2021
1 parent 338b999 commit 4b9cb2106c688574ed0f6602818ee9683e802ee7
@@ -376,6 +376,7 @@ void runToolkit() {
launchLatch.countDown();
try {
Application.invokeAndWait(this.userRunnable);
this.userRunnable = null;

if (getPrimaryTimer().isFullspeed()) {
/*
@@ -0,0 +1,55 @@
/*
* Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation. Oracle designates this
* particular file as subject to the "Classpath" exception as provided
* by Oracle in the LICENSE file that accompanied this code.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/

package test.com.sun.javafx.application;

import javafx.application.Platform;
import org.junit.Test;
import org.junit.AfterClass;
import test.util.memory.JMemoryBuddy;

public class PlatformStartupMemoryLeakTest {

@Test
public void testStartupLeak() {
JMemoryBuddy.memoryTest((checker) -> {
// This Runnable must not turn into a lambda, because then the test wouldn't work anymore.
Runnable r = new Runnable() {
@Override
public void run() {
System.out.println("Startup called!");
}
};
Platform.startup(r);
checker.assertCollectable(r);
});
}

@AfterClass
public static void tearDown() {
Platform.exit();
}

}

1 comment on commit 4b9cb21

@openjdk-notifier

This comment has been minimized.

Copy link

@openjdk-notifier openjdk-notifier bot commented on 4b9cb21 Sep 23, 2021

Please sign in to comment.