8335216: [windows] Missing error check for GetSystemDirectory in glass

Reviewed-by: mstrauss, kcr

Author: Lukasz Kostyra

modules/javafx.graphics/src/main/native-glass/win/RoActivationSupport.cpp

@@ -69,12 +69,19 @@ void tryInitializeRoActivationSupport()
     wchar_t path[MAX_PATH];
     wchar_t file[MAX_PATH];
 
-    if (GetSystemDirectory(path, sizeof(path) / sizeof(wchar_t)) == 0) {
+    UINT pathSize = sizeof(path) / sizeof(wchar_t);
+    UINT rval = GetSystemDirectoryW(path, pathSize);
+    if (rval == 0 || rval >= pathSize) {
+        fprintf(stderr, "WinRT: Failed to fetch system directory");
         return;
     }
 
     memcpy_s(file, sizeof(file), path, sizeof(path));
-    wcscat_s(file, MAX_PATH-1, L"\\combase.dll");
+    if (wcscat_s(file, MAX_PATH-1, L"\\combase.dll") != 0) {
+        fprintf(stderr, "WinRT: Failed to form path to combase.dll");
+        return;
+    }
+
     hLibComBase = LoadLibraryW(file);
     if (!hLibComBase) {
         fprintf(stderr, moduleNotFoundMessage, "combase.dll");