Skip to content

Commit

Permalink
8338306: WebView Drag and Drop fails with WebKit 619.1
Browse files Browse the repository at this point in the history 
Reviewed-by: kcr, sykora
  • Loading branch information
Hima Bindu Meda committed Aug 21, 2024
1 parent f1bac5a commit 67ac9d7
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion modules/javafx.web/src/main/native/Source/WebKitLegacy/java/WebCoreSupport/WebPage.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2250,8 +2250,10 @@ JNIEXPORT jint JNICALL Java_com_sun_webkit_WebPage_twkProcessDrag
case com_sun_webkit_WebPage_DND_DST_EXIT:
dc.dragExited(*localMainFrame,WTFMove(dragData));
return 0;
case com_sun_webkit_WebPage_DND_DST_ENTER:
case com_sun_webkit_WebPage_DND_DST_OVER:

case com_sun_webkit_WebPage_DND_DST_CHANGE:
return dragOperationToDragCursor(std::get<std::optional<WebCore::DragOperation>>(dc.dragEnteredOrUpdated(*localMainFrame, WTFMove(dragData))));
case com_sun_webkit_WebPage_DND_DST_DROP:
{
int ret = dc.performDragOperation(WTFMove(dragData)) ? 1 : 0;
Expand Down

7 comments on commit 67ac9d7

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

@HimaBinduMeda
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jfx23u

@openjdk
Copy link

@openjdk openjdk bot commented on 67ac9d7 Aug 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HimaBinduMeda the backport was successfully created on the branch backport-HimaBinduMeda-67ac9d78-master in my personal fork of openjdk/jfx23u. To create a pull request with this backport targeting openjdk/jfx23u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 67ac9d78 from the openjdk/jfx repository.

The commit being backported was authored by Hima Bindu Meda on 21 Aug 2024 and was reviewed by Kevin Rushforth and Joeri Sykora.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jfx23u:

$ git fetch https://github.com/openjdk-bots/jfx23u.git backport-HimaBinduMeda-67ac9d78-master:backport-HimaBinduMeda-67ac9d78-master
$ git checkout backport-HimaBinduMeda-67ac9d78-master
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jfx23u.git backport-HimaBinduMeda-67ac9d78-master

@johanvos
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jfx17u

@johanvos
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jfx21u

@openjdk
Copy link

@openjdk openjdk bot commented on 67ac9d7 Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johanvos the backport was successfully created on the branch backport-johanvos-67ac9d78-master in my personal fork of openjdk/jfx17u. To create a pull request with this backport targeting openjdk/jfx17u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 67ac9d78 from the openjdk/jfx repository.

The commit being backported was authored by Hima Bindu Meda on 21 Aug 2024 and was reviewed by Kevin Rushforth and Joeri Sykora.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jfx17u:

$ git fetch https://github.com/openjdk-bots/jfx17u.git backport-johanvos-67ac9d78-master:backport-johanvos-67ac9d78-master
$ git checkout backport-johanvos-67ac9d78-master
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jfx17u.git backport-johanvos-67ac9d78-master

@openjdk
Copy link

@openjdk openjdk bot commented on 67ac9d7 Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johanvos the backport was successfully created on the branch backport-johanvos-67ac9d78-master in my personal fork of openjdk/jfx21u. To create a pull request with this backport targeting openjdk/jfx21u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 67ac9d78 from the openjdk/jfx repository.

The commit being backported was authored by Hima Bindu Meda on 21 Aug 2024 and was reviewed by Kevin Rushforth and Joeri Sykora.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jfx21u:

$ git fetch https://github.com/openjdk-bots/jfx21u.git backport-johanvos-67ac9d78-master:backport-johanvos-67ac9d78-master
$ git checkout backport-johanvos-67ac9d78-master
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jfx21u.git backport-johanvos-67ac9d78-master

Please sign in to comment.