Skip to content

Commit

Permalink
8319231: Unrecognized "minimum" key in .jcheck/conf causes /reviewers…
Browse files Browse the repository at this point in the history
… command to be ignored

Reviewed-by: ehelin, angorya
  • Loading branch information
kevinrushforth committed Nov 1, 2023
1 parent 6104113 commit 72c052e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .jcheck/conf
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ domain=openjdk.org
files=.*\.java$|.*\.c$|.*\.h$|.*\.cpp$|.*\.hpp$|.*\.cc$|.*\.jsl$|.*\.fxml$|.*\.css$|.*\.m$|.*\.mm$|.*\.frag$|.*\.vert$|.*\.hlsl$|.*\.metal$|.*\.gradle$|.*\.groovy$|.*\.g4$|.*\.stg$

[checks "reviewers"]
minimum=1
reviewers=1

[checks "merge"]
message=Merge
Expand Down

3 comments on commit 72c052e

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinrushforth
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jfx21u

@openjdk
Copy link

@openjdk openjdk bot commented on 72c052e Nov 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinrushforth the backport was successfully created on the branch kevinrushforth-backport-72c052ee in my personal fork of openjdk/jfx21u. To create a pull request with this backport targeting openjdk/jfx21u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 72c052ee from the openjdk/jfx repository.

The commit being backported was authored by Kevin Rushforth on 1 Nov 2023 and was reviewed by Erik Duveblad and Andy Goryachev.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jfx21u:

$ git fetch https://github.com/openjdk-bots/jfx21u.git kevinrushforth-backport-72c052ee:kevinrushforth-backport-72c052ee
$ git checkout kevinrushforth-backport-72c052ee
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jfx21u.git kevinrushforth-backport-72c052ee

Please sign in to comment.