8281953: NullPointer in InputMethod components in JFXPanel

Reviewed-by: aghaisas

Author: eduardsdv

modules/javafx.controls/src/main/java/javafx/scene/control/skin/TextInputControlSkin.java

@@ -334,7 +334,10 @@ protected boolean computeValue() {
         control.setInputMethodRequests(new ExtendedInputMethodRequests() {
             @Override public Point2D getTextLocation(int offset) {
                 Scene scene = getSkinnable().getScene();
-                Window window = scene.getWindow();
+                Window window = scene != null ? scene.getWindow() : null;
+                if (window == null) {
+                    return new Point2D(0, 0);
+                }
                 // Don't use imstart here because it isn't initialized yet.
                 Rectangle2D characterBounds = getCharacterBounds(control.getSelection().getStart() + offset);
                 Point2D p = getSkinnable().localToScene(characterBounds.getMinX(), characterBounds.getMaxY());

modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/TextInputControlSkinTest.java

@@ -26,12 +26,14 @@
 package test.javafx.scene.control.skin;
 
 import java.util.concurrent.atomic.AtomicBoolean;
+import javafx.geometry.Point2D;
 import javafx.scene.control.TextArea;
 import javafx.scene.control.TextField;
 import javafx.scene.control.PasswordField;
 import javafx.scene.control.skin.TextAreaSkin;
 import javafx.scene.control.skin.TextFieldSkin;
 import org.junit.Test;
+import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertTrue;
 
@@ -92,6 +94,17 @@ public class TextInputControlSkinTest {
         passwordField.setText(null);
     }
 
+    @Test public void noNullPointerIfTextInputNotInScene() {
+        TextField textField = new TextField();
+        TextFieldSkin skin = new TextFieldSkin(textField);
+        textField.setSkin(skin);
+
+        // Check that no NullPointerException is thrown if the TextField is not in scene
+        // and that the default point is returned.
+        Point2D point = textField.getInputMethodRequests().getTextLocation(0);
+        assertEquals(new Point2D(0, 0), point);
+    }
+
     public class FocusableTextField extends TextField {
         public void setFocus(boolean value) {
             super.setFocused(value);