8279228: Leak in ScrollPaneSkin, related to touch events

Reviewed-by: aghaisas, kcr
openjdk · Feb 23, 2022 · adf1da4 · adf1da4 · openjdk-notifier · Feb 23, 2022
1 parent 6f201f7
commit adf1da4
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/modules/javafx.controls/src/main/java/javafx/scene/control/skin/ScrollPaneSkin.java b/modules/javafx.controls/src/main/java/javafx/scene/control/skin/ScrollPaneSkin.java
@@ -25,6 +25,7 @@
 
 package javafx.scene.control.skin;
 
+import com.sun.javafx.scene.NodeHelper;
 import com.sun.javafx.scene.ParentHelper;
 import com.sun.javafx.scene.control.Properties;
 import com.sun.javafx.scene.control.behavior.BehaviorBase;
@@ -1200,7 +1201,7 @@ private void startSBReleasedAnimation() {
             sbTouchTimeline = new Timeline();
             sbTouchKF1 = new KeyFrame(Duration.millis(0), event -> {
                 tempVisibility = true;
-                if (touchDetected == true || mouseDown == true) {
+                if ((touchDetected == true || mouseDown == true) && NodeHelper.isTreeShowing(getSkinnable())) {
                     sbTouchTimeline.playFromStart();
                 }
             });