Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
8251352: Many javafx.base classes have implicit no-arg constructors
Reviewed-by: nlisker, kcr
  • Loading branch information
bhaweshkc authored and kevinrushforth committed Aug 18, 2020
1 parent 2aed5ad commit b25ffc7
Show file tree
Hide file tree
Showing 35 changed files with 224 additions and 0 deletions.
Expand Up @@ -60,6 +60,12 @@
public abstract class DoubleProperty extends ReadOnlyDoubleProperty implements
Property<Number>, WritableDoubleValue {

/**
* Creates a default {@code DoubleProperty}.
*/
public DoubleProperty() {
}

/**
* {@inheritDoc}
*/
Expand Down
Expand Up @@ -59,6 +59,12 @@
public abstract class FloatProperty extends ReadOnlyFloatProperty implements
Property<Number>, WritableFloatValue {

/**
* Creates a default {@code FloatProperty}.
*/
public FloatProperty() {
}

/**
* {@inheritDoc}
*/
Expand Down
Expand Up @@ -59,6 +59,12 @@
public abstract class IntegerProperty extends ReadOnlyIntegerProperty implements
Property<Number>, WritableIntegerValue {

/**
* Creates a default {@code IntegerProperty}.
*/
public IntegerProperty() {
}

/**
* {@inheritDoc}
*/
Expand Down
Expand Up @@ -55,6 +55,13 @@
*/
public abstract class ListProperty<E> extends ReadOnlyListProperty<E> implements
Property<ObservableList<E>>, WritableListValue<E> {

/**
* Creates a default {@code ListProperty}.
*/
public ListProperty() {
}

/**
* {@inheritDoc}
*/
Expand Down
Expand Up @@ -58,6 +58,12 @@
public abstract class LongProperty extends ReadOnlyLongProperty implements
Property<Number>, WritableLongValue {

/**
* Creates a default {@code LongProperty}.
*/
public LongProperty() {
}

/**
* {@inheritDoc}
*/
Expand Down
Expand Up @@ -56,6 +56,13 @@
*/
public abstract class MapProperty<K, V> extends ReadOnlyMapProperty<K, V> implements
Property<ObservableMap<K, V>>, WritableMapValue<K, V> {

/**
* Creates a default {@code MapProperty}.
*/
public MapProperty() {
}

/**
* {@inheritDoc}
*/
Expand Down
Expand Up @@ -64,6 +64,12 @@
public abstract class ObjectProperty<T> extends ReadOnlyObjectProperty<T>
implements Property<T>, WritableObjectValue<T> {

/**
* Creates a default {@code ObjectProperty}.
*/
public ObjectProperty() {
}

/**
* {@inheritDoc}
*/
Expand Down
Expand Up @@ -41,6 +41,12 @@ public abstract class ReadOnlyBooleanPropertyBase extends ReadOnlyBooleanPropert

ExpressionHelper<Boolean> helper;

/**
* Creates a default {@code ReadOnlyBooleanPropertyBase}.
*/
public ReadOnlyBooleanPropertyBase() {
}

@Override
public void addListener(InvalidationListener listener) {
helper = ExpressionHelper.addListener(helper, this, listener);
Expand Down
Expand Up @@ -41,6 +41,12 @@ public abstract class ReadOnlyDoublePropertyBase extends ReadOnlyDoubleProperty

ExpressionHelper<Number> helper;

/**
* Creates a default {@code ReadOnlyDoublePropertyBase}.
*/
public ReadOnlyDoublePropertyBase() {
}

@Override
public void addListener(InvalidationListener listener) {
helper = ExpressionHelper.addListener(helper, this, listener);
Expand Down
Expand Up @@ -41,6 +41,12 @@ public abstract class ReadOnlyFloatPropertyBase extends ReadOnlyFloatProperty {

ExpressionHelper<Number> helper;

/**
* Creates a default {@code ReadOnlyFloatPropertyBase}.
*/
public ReadOnlyFloatPropertyBase() {
}

@Override
public void addListener(InvalidationListener listener) {
helper = ExpressionHelper.addListener(helper, this, listener);
Expand Down
Expand Up @@ -41,6 +41,12 @@ public abstract class ReadOnlyIntegerPropertyBase extends ReadOnlyIntegerPropert

ExpressionHelper<Number> helper;

/**
* Creates a default {@code ReadOnlyIntegerPropertyBase}.
*/
public ReadOnlyIntegerPropertyBase() {
}

@Override
public void addListener(InvalidationListener listener) {
helper = ExpressionHelper.addListener(helper, this, listener);
Expand Down
Expand Up @@ -43,6 +43,12 @@ public abstract class ReadOnlyListPropertyBase<E> extends ReadOnlyListProperty<E

private ListExpressionHelper<E> helper;

/**
* Creates a default {@code ReadOnlyListPropertyBase}.
*/
public ReadOnlyListPropertyBase() {
}

@Override
public void addListener(InvalidationListener listener) {
helper = ListExpressionHelper.addListener(helper, this, listener);
Expand Down
Expand Up @@ -41,6 +41,12 @@ public abstract class ReadOnlyLongPropertyBase extends ReadOnlyLongProperty {

ExpressionHelper<Number> helper;

/**
* Creates a default {@code ReadOnlyLongPropertyBase}.
*/
public ReadOnlyLongPropertyBase() {
}

@Override
public void addListener(InvalidationListener listener) {
helper = ExpressionHelper.addListener(helper, this, listener);
Expand Down
Expand Up @@ -42,6 +42,12 @@ public abstract class ReadOnlyMapPropertyBase<K, V> extends ReadOnlyMapProperty<

private MapExpressionHelper<K, V> helper;

/**
* Creates a default {@code ReadOnlyMapPropertyBase}.
*/
public ReadOnlyMapPropertyBase() {
}

@Override
public void addListener(InvalidationListener listener) {
helper = MapExpressionHelper.addListener(helper, this, listener);
Expand Down
Expand Up @@ -43,6 +43,12 @@ public abstract class ReadOnlyObjectPropertyBase<T> extends ReadOnlyObjectProper

ExpressionHelper<T> helper;

/**
* Creates a default {@code ReadOnlyObjectPropertyBase}.
*/
public ReadOnlyObjectPropertyBase() {
}

@Override
public void addListener(InvalidationListener listener) {
helper = ExpressionHelper.addListener(helper, this, listener);
Expand Down
Expand Up @@ -44,6 +44,12 @@ public abstract class ReadOnlySetPropertyBase<E> extends ReadOnlySetProperty<E>

private SetExpressionHelper<E> helper;

/**
* Creates a default {@code ReadOnlySetPropertyBase}.
*/
public ReadOnlySetPropertyBase() {
}

@Override
public void addListener(InvalidationListener listener) {
helper = SetExpressionHelper.addListener(helper, this, listener);
Expand Down
Expand Up @@ -41,6 +41,12 @@ public abstract class ReadOnlyStringPropertyBase extends ReadOnlyStringProperty

ExpressionHelper<String> helper;

/**
* Creates a default {@code ReadOnlyStringPropertyBase}.
*/
public ReadOnlyStringPropertyBase() {
}

@Override
public void addListener(InvalidationListener listener) {
helper = ExpressionHelper.addListener(helper, this, listener);
Expand Down
Expand Up @@ -57,6 +57,13 @@
*/
public abstract class SetProperty<E> extends ReadOnlySetProperty<E> implements
Property<ObservableSet<E>>, WritableSetValue<E> {

/**
* Creates a default {@code SetProperty}.
*/
public SetProperty() {
}

/**
* {@inheritDoc}
*/
Expand Down
Expand Up @@ -57,6 +57,12 @@
public abstract class StringProperty extends ReadOnlyStringProperty implements
Property<String>, WritableStringValue {

/**
* Creates a default {@code StringProperty}.
*/
public StringProperty() {
}

/**
* {@inheritDoc}
*/
Expand Down
Expand Up @@ -47,6 +47,12 @@ public abstract class ObservableValueBase<T> implements ObservableValue<T> {

private ExpressionHelper<T> helper;

/**
* Creates a default {@code ObservableValueBase}.
*/
public ObservableValueBase() {
}

/**
* {@inheritDoc}
*/
Expand Down
Expand Up @@ -80,6 +80,12 @@
*/
public abstract class ModifiableObservableListBase<E> extends ObservableListBase<E> {

/**
* Creates a default {@code ModifiableObservableListBase}.
*/
public ModifiableObservableListBase() {
}

@Override
public boolean setAll(Collection<? extends E> col) {
beginChange();
Expand Down
Expand Up @@ -42,6 +42,12 @@ public abstract class ObservableArrayBase<T extends ObservableArray<T>> implemen

private ArrayListenerHelper<T> listenerHelper;

/**
* Creates a default {@code ObservableArrayBase}.
*/
public ObservableArrayBase() {
}

@Override public final void addListener(InvalidationListener listener) {
listenerHelper = ArrayListenerHelper.<T>addListener(listenerHelper, (T) this, listener);
}
Expand Down
Expand Up @@ -93,6 +93,12 @@ public abstract class ObservableListBase<E> extends AbstractList<E> implements
private ListListenerHelper<E> listenerHelper;
private final ListChangeBuilder<E> changeBuilder = new ListChangeBuilder<E>(this);

/**
* Creates a default {@code ObservableListBase}.
*/
public ObservableListBase() {
}

/**
* Adds a new update operation to the change.
* <p><strong>Note</strong>: needs to be called inside {@code beginChange()} / {@code endChange()} block.
Expand Down
Expand Up @@ -32,6 +32,13 @@
* @since JavaFX 2.0
*/
public abstract class StringConverter<T> {

/**
* Creates a default {@code StringConverter}.
*/
public StringConverter() {
}

/**
* Converts the object provided into its string form.
* Format of the returned string is defined by the specific converter.
Expand Down
Expand Up @@ -34,6 +34,12 @@
*/
public class BigDecimalStringConverter extends StringConverter<BigDecimal> {

/**
* Creates a default {@code BigDecimalStringConverter}.
*/
public BigDecimalStringConverter() {
}

/** {@inheritDoc} */
@Override public BigDecimal fromString(String value) {
// If the specified value is null or zero-length, return null
Expand Down
Expand Up @@ -33,6 +33,13 @@
* @since JavaFX 2.1
*/
public class BigIntegerStringConverter extends StringConverter<BigInteger> {

/**
* Creates a default {@code BigIntegerStringConverter}.
*/
public BigIntegerStringConverter() {
}

/** {@inheritDoc} */
@Override public BigInteger fromString(String value) {
// If the specified value is null or zero-length, return null
Expand Down
Expand Up @@ -33,6 +33,13 @@
* @since JavaFX 2.1
*/
public class BooleanStringConverter extends StringConverter<Boolean> {

/**
* Creates a default {@code BooleanStringConverter}.
*/
public BooleanStringConverter() {
}

/** {@inheritDoc} */
@Override public Boolean fromString(String value) {
// If the specified value is null or zero-length, return null
Expand Down
Expand Up @@ -33,6 +33,13 @@
* @since JavaFX 2.1
*/
public class ByteStringConverter extends StringConverter<Byte> {

/**
* Creates a default {@code ByteStringConverter}.
*/
public ByteStringConverter() {
}

/** {@inheritDoc} */
@Override public Byte fromString(String value) {
// If the specified value is null or zero-length, return null
Expand Down
Expand Up @@ -33,6 +33,13 @@
* @since JavaFX 2.1
*/
public class CharacterStringConverter extends StringConverter<Character> {

/**
* Creates a default {@code CharacterStringConverter}.
*/
public CharacterStringConverter() {
}

/** {@inheritDoc} */
@Override public Character fromString(String value) {
// If the specified value is null or zero-length, return null
Expand Down
Expand Up @@ -32,6 +32,13 @@
* @since JavaFX 2.1
*/
public class DefaultStringConverter extends StringConverter<String> {

/**
* Creates a default {@code DefaultStringConverter}.
*/
public DefaultStringConverter() {
}

/** {@inheritDoc} */
@Override public String toString(String value) {
return (value != null) ? value : "";
Expand Down

0 comments on commit b25ffc7

Please sign in to comment.