8349105: Pagination: exception initializing in a background thread

Reviewed-by: kcr, mstrauss

Author: Andy Goryachev

modules/javafx.controls/src/main/java/javafx/scene/control/skin/PaginationSkin.java

@@ -127,16 +127,12 @@ public class PaginationSkin extends SkinBase<Pagination> {
     private boolean nextPageReached = false;
     private boolean setInitialDirection = false;
     private int direction;
-
     private int currentAnimatedIndex;
-    private boolean hasPendingAnimation = false;
-
+    private volatile boolean hasPendingAnimation;
     private boolean animate = true;
-
     private final PaginationBehavior behavior;
 
 
-
     /* *************************************************************************
      *                                                                         *
      * Listeners                                                               *
@@ -712,6 +708,10 @@ private int getCurrentPageIndex() {
     }
 
     private void animateSwitchPage() {
+        if (!Platform.isFxApplicationThread()) {
+            hasPendingAnimation = true;
+            return;
+        }
         if (timeline != null) {
             timeline.setRate(8);
             hasPendingAnimation = true;

tests/system/src/test/java/test/robot/javafx/scene/NodeInitializationStressTest.java

@@ -402,7 +402,6 @@ public void menuButton() {
         });
     }
 
-    @Disabled("JDK-8349105") // FIX
     @Test
     public void pagination() {
         assumeFalse(SKIP_TEST);
@@ -414,9 +413,10 @@ public void pagination() {
             c.setPageFactory((pageIndex) -> {
                 return new Label(pageIndex + " " + nextString());
             });
-            c.setPageCount(100);
-            c.setCurrentPageIndex(nextInt(100));
+            int mx = 1 + nextInt(100);
             accessControl(c);
+            c.setPageCount(mx);
+            c.setCurrentPageIndex(nextInt(mx));
         });
     }