Skip to content

Commit

Permalink
8318984: Update to Xcode 14.3.1 on macOS
Browse files Browse the repository at this point in the history 
Reviewed-by: arapte, sykora
  • Loading branch information
@kevinrushforth
kevinrushforth committed Nov 14, 2023
1 parent 8dd3c37 commit d24e96a
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/submit.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ jobs:
java -version
which ant
ant -version
sudo xcode-select --switch /Applications/Xcode_14.3.app/Contents/Developer
sudo xcode-select --switch /Applications/Xcode_14.3.1.app/Contents/Developer
xcodebuild -version
- name: Build JavaFX artifacts
Expand Down
2 changes: 1 addition & 1 deletion build.properties
View file
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ jfx.gradle.version.min=7.3
# Toolchains
jfx.build.linux.gcc.version=gcc12.2.0-OL6.4+1.0
jfx.build.windows.msvc.version=VS2022-17.5.0+1.0
jfx.build.macosx.xcode.version=Xcode14.3+1.0
jfx.build.macosx.xcode.version=Xcode14.3.1+1.0

# Build tools
jfx.build.cmake.version=3.22.3
Expand Down
6 changes: 3 additions & 3 deletions gradle/verification-metadata.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,9 @@
<sha256 value="80a34006e232b06c7790c6e05839b3e02a663846f54aff0c10aec5d97e6cebb4" origin="Generated by Gradle"/>
</artifact>
</component>
<component group="javafx" name="devkit-macosx" version="Xcode14.3+1.0.tar">
<artifact name="devkit-macosx-Xcode14.3+1.0.tar.gz">
<sha256 value="90011895771bd98c16ea38d180935784fd99f1273ff7537125a4f97949e7e73c" origin="Generated by Gradle"/>
<component group="javafx" name="devkit-macosx" version="Xcode14.3.1+1.0.tar">
<artifact name="devkit-macosx-Xcode14.3.1+1.0.tar.gz">
<sha256 value="6b8ac317a9c2f255060067cfa596d94f6635d51f2eb5c08fe05110cf99e1ac14" origin="Generated by Gradle"/>
</artifact>
</component>
<component group="javafx" name="devkit-windows_x64-VS2022" version="17.5.0+1.0.tar">
Expand Down

5 comments on commit d24e96a

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

@kevinrushforth
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jfx21u

@openjdk
Copy link

@openjdk openjdk bot commented on d24e96a Nov 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinrushforth the backport was successfully created on the branch kevinrushforth-backport-d24e96a6 in my personal fork of openjdk/jfx21u. To create a pull request with this backport targeting openjdk/jfx21u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit d24e96a6 from the openjdk/jfx repository.

The commit being backported was authored by Kevin Rushforth on 14 Nov 2023 and was reviewed by Ambarish Rapte and Joeri Sykora.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jfx21u:

$ git fetch https://github.com/openjdk-bots/jfx21u.git kevinrushforth-backport-d24e96a6:kevinrushforth-backport-d24e96a6
$ git checkout kevinrushforth-backport-d24e96a6
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jfx21u.git kevinrushforth-backport-d24e96a6

@sercher
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jfx17u

@openjdk
Copy link

@openjdk openjdk bot commented on d24e96a Sep 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sercher the backport was successfully created on the branch backport-sercher-d24e96a6-master in my personal fork of openjdk/jfx17u. To create a pull request with this backport targeting openjdk/jfx17u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit d24e96a6 from the openjdk/jfx repository.

The commit being backported was authored by Kevin Rushforth on 14 Nov 2023 and was reviewed by Ambarish Rapte and Joeri Sykora.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jfx17u:

$ git fetch https://github.com/openjdk-bots/jfx17u.git backport-sercher-d24e96a6-master:backport-sercher-d24e96a6-master
$ git checkout backport-sercher-d24e96a6-master
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jfx17u.git backport-sercher-d24e96a6-master

⚠️ @sercher You are not yet a collaborator in my fork openjdk-bots/jfx17u. An invite will be sent out and you need to accept it before you can proceed.

Please sign in to comment.