Skip to content

Commit

Permalink
8315870: icu fails to compile with Visual Studio 2022 17.6.5
Browse files Browse the repository at this point in the history 
Reviewed-by: arapte, jvos
  • Loading branch information
@kevinrushforth
kevinrushforth committed Sep 8, 2023
1 parent 8fcd6e5 commit ed92171
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/i18n/fmtable.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ using number::impl::DecimalQuantity;
// Return true if *a == *b.
static inline UBool objectEquals(const UObject* a, const UObject* b) {
// LATER: return *a == *b;
return *((const Measure*) a) == *((const Measure*) b);
return *((const Measure*) a) == *b;
}

// Return a clone of *a.
Expand Down

5 comments on commit ed92171

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

@kevinrushforth
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jfx21u

@openjdk
Copy link

@openjdk openjdk bot commented on ed92171 Sep 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinrushforth the backport was successfully created on the branch kevinrushforth-backport-ed921717 in my personal fork of openjdk/jfx21u. To create a pull request with this backport targeting openjdk/jfx21u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit ed921717 from the openjdk/jfx repository.

The commit being backported was authored by Kevin Rushforth on 8 Sep 2023 and was reviewed by Ambarish Rapte and Johan Vos.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jfx21u:

$ git fetch https://github.com/openjdk-bots/jfx21u.git kevinrushforth-backport-ed921717:kevinrushforth-backport-ed921717
$ git checkout kevinrushforth-backport-ed921717
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jfx21u.git kevinrushforth-backport-ed921717

@johanvos
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jfx17u

@openjdk
Copy link

@openjdk openjdk bot commented on ed92171 Oct 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johanvos the backport was successfully created on the branch backport-johanvos-ed921717-master in my personal fork of openjdk/jfx17u. To create a pull request with this backport targeting openjdk/jfx17u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit ed921717 from the openjdk/jfx repository.

The commit being backported was authored by Kevin Rushforth on 8 Sep 2023 and was reviewed by Ambarish Rapte and Johan Vos.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jfx17u:

$ git fetch https://github.com/openjdk-bots/jfx17u.git backport-johanvos-ed921717-master:backport-johanvos-ed921717-master
$ git checkout backport-johanvos-ed921717-master
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jfx17u.git backport-johanvos-ed921717-master

Please sign in to comment.