Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
8249647: Many classes in package javafx.beans.binding in module javaf…
…x.base have implicit no-arg constructors

Reviewed-by: nlisker, kcr
  • Loading branch information
aghaisas committed Jul 28, 2020
1 parent 6b00892 commit fc38ce6
Show file tree
Hide file tree
Showing 21 changed files with 116 additions and 2 deletions.
Expand Up @@ -60,7 +60,7 @@ public abstract class BooleanBinding extends BooleanExpression implements
Binding<Boolean> {

/**
* Sole constructor
* Creates a default {@code BooleanBinding}.
*/
public BooleanBinding() {
}
Expand Down
Expand Up @@ -45,7 +45,7 @@
public abstract class BooleanExpression implements ObservableBooleanValue {

/**
* Sole constructor
* Creates a default {@code BooleanExpression}.
*/
public BooleanExpression() {
}
Expand Down
Expand Up @@ -116,6 +116,12 @@ public abstract class DoubleBinding extends DoubleExpression implements
private BindingHelperObserver observer;
private ExpressionHelper<Number> helper = null;

/**
* Creates a default {@code DoubleBinding}.
*/
public DoubleBinding() {
}

@Override
public void addListener(InvalidationListener listener) {
helper = ExpressionHelper.addListener(helper, this, listener);
Expand Down
Expand Up @@ -44,6 +44,12 @@
public abstract class DoubleExpression extends NumberExpressionBase implements
ObservableDoubleValue {

/**
* Creates a default {@code DoubleExpression}.
*/
public DoubleExpression() {
}

@Override
public int intValue() {
return (int) get();
Expand Down
Expand Up @@ -66,6 +66,12 @@ public abstract class FloatBinding extends FloatExpression implements
private BindingHelperObserver observer;
private ExpressionHelper<Number> helper = null;

/**
* Creates a default {@code FloatBinding}.
*/
public FloatBinding() {
}

@Override
public void addListener(InvalidationListener listener) {
helper = ExpressionHelper.addListener(helper, this, listener);
Expand Down
Expand Up @@ -43,6 +43,12 @@
public abstract class FloatExpression extends NumberExpressionBase implements
ObservableFloatValue {

/**
* Creates a default {@code FloatExpression}.
*/
public FloatExpression() {
}

@Override
public int intValue() {
return (int) get();
Expand Down
Expand Up @@ -66,6 +66,12 @@ public abstract class IntegerBinding extends IntegerExpression implements
private BindingHelperObserver observer;
private ExpressionHelper<Number> helper = null;

/**
* Creates a default {@code IntegerBinding}.
*/
public IntegerBinding() {
}

@Override
public void addListener(InvalidationListener listener) {
helper = ExpressionHelper.addListener(helper, this, listener);
Expand Down
Expand Up @@ -43,6 +43,12 @@
public abstract class IntegerExpression extends NumberExpressionBase implements
ObservableIntegerValue {

/**
* Creates a default {@code IntegerExpression}.
*/
public IntegerExpression() {
}

@Override
public int intValue() {
return get();
Expand Down
Expand Up @@ -64,6 +64,12 @@
*/
public abstract class ListBinding<E> extends ListExpression<E> implements Binding<ObservableList<E>> {

/**
* Creates a default {@code ListBinding}.
*/
public ListBinding() {
}

private final ListChangeListener<E> listChangeListener = new ListChangeListener<E>() {
@Override
public void onChanged(Change<? extends E> change) {
Expand Down
Expand Up @@ -57,6 +57,12 @@ public abstract class ListExpression<E> implements ObservableListValue<E> {

private static final ObservableList EMPTY_LIST = FXCollections.emptyObservableList();

/**
* Creates a default {@code ListExpression}.
*/
public ListExpression() {
}

@Override
public ObservableList<E> getValue() {
return get();
Expand Down
Expand Up @@ -66,6 +66,12 @@ public abstract class LongBinding extends LongExpression implements
private BindingHelperObserver observer;
private ExpressionHelper<Number> helper = null;

/**
* Creates a default {@code LongBinding}.
*/
public LongBinding() {
}

@Override
public void addListener(InvalidationListener listener) {
helper = ExpressionHelper.addListener(helper, this, listener);
Expand Down
Expand Up @@ -42,6 +42,12 @@
public abstract class LongExpression extends NumberExpressionBase implements
ObservableLongValue {

/**
* Creates a default {@code LongExpression}.
*/
public LongExpression() {
}

@Override
public int intValue() {
return (int) get();
Expand Down
Expand Up @@ -84,6 +84,12 @@ public void onChanged(Change<? extends K, ? extends V> change) {
private SizeProperty size0;
private EmptyProperty empty0;

/**
* Creates a default {@code MapBinding}.
*/
public MapBinding() {
}

@Override
public ReadOnlyIntegerProperty sizeProperty() {
if (size0 == null) {
Expand Down
Expand Up @@ -91,6 +91,12 @@ public ObservableMap<K, V> getValue() {
return get();
}

/**
* Creates a default {@code MapExpression}.
*/
public MapExpression() {
}

/**
* Returns a {@code MapExpression} that wraps a
* {@link javafx.beans.value.ObservableMapValue}. If the
Expand Down
Expand Up @@ -49,6 +49,12 @@
*/
public abstract class NumberExpressionBase implements NumberExpression {

/**
* Creates a default {@code NumberExpressionBase}.
*/
public NumberExpressionBase() {
}

/**
* Returns an {@code NumberExpressionBase} that wraps a
* {@link javafx.beans.value.ObservableNumberValue}. If the
Expand Down
Expand Up @@ -66,6 +66,12 @@ public abstract class ObjectBinding<T> extends ObjectExpression<T> implements
private BindingHelperObserver observer;
private ExpressionHelper<T> helper = null;

/**
* Creates a default {@code ObjectBinding}.
*/
public ObjectBinding() {
}

@Override
public void addListener(InvalidationListener listener) {
helper = ExpressionHelper.addListener(helper, this, listener);
Expand Down
Expand Up @@ -49,6 +49,12 @@ public T getValue() {
return get();
}

/**
* Creates a default {@code ObjectExpression}.
*/
public ObjectExpression() {
}

/**
* Returns an {@code ObjectExpression} that wraps an
* {@link javafx.beans.value.ObservableObjectValue}. If the
Expand Down
Expand Up @@ -65,6 +65,12 @@
*/
public abstract class SetBinding<E> extends SetExpression<E> implements Binding<ObservableSet<E>> {

/**
* Creates a default {@code SetBinding}.
*/
public SetBinding() {
}

private final SetChangeListener<E> setChangeListener = new SetChangeListener<E>() {
@Override
public void onChanged(Change<? extends E> change) {
Expand Down
Expand Up @@ -57,6 +57,12 @@
*/
public abstract class SetExpression<E> implements ObservableSetValue<E> {

/**
* Creates a default {@code SetExpression}.
*/
public SetExpression() {
}

private static final ObservableSet EMPTY_SET = new EmptyObservableSet();

private static class EmptyObservableSet<E> extends AbstractSet<E> implements ObservableSet<E> {
Expand Down
Expand Up @@ -65,6 +65,12 @@ public abstract class StringBinding extends StringExpression implements
private BindingHelperObserver observer;
private ExpressionHelper<String> helper = null;

/**
* Creates a default {@code StringBinding}.
*/
public StringBinding() {
}

@Override
public void addListener(InvalidationListener listener) {
helper = ExpressionHelper.addListener(helper, this, listener);
Expand Down
Expand Up @@ -46,6 +46,12 @@
*/
public abstract class StringExpression implements ObservableStringValue {

/**
* Creates a default {@code StringExpression}.
*/
public StringExpression() {
}

@Override
public String getValue() {
return get();
Expand Down

0 comments on commit fc38ce6

Please sign in to comment.