-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8237003: Remove hardcoded WebAnimationsCSSIntegrationEnabled flag in DumpRenderTree #100
Conversation
👋 Welcome back ghb! A progress list of the required criteria for merging this PR into |
@guruhb This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type
Since the source branch of this PR was last updated there have been 4 commits pushed to the ➡️ To integrate this PR with the above commit message, type |
This fix only affects the test framework, so a single reviewer is fine. |
/integrate |
@guruhb The following commits have been pushed to master since your change was applied:
Your commit was automatically rebased without conflicts. Pushed as commit b96bc52. |
Mailing list message from Guru Hb on openjfx-dev: Changeset: b96bc52 8237003: Remove hardcoded WebAnimationsCSSIntegrationEnabled flag in DumpRenderTree Reviewed-by: kcr ! modules/javafx.web/src/main/java/com/sun/javafx/webkit/drt/DumpRenderTree.java |
AnimationBase and WebAnimation are two different abstract animation API provider. By default KeyFrameAnimation (which is a sub class of AnimationBase) is used for controlling and rendering the CSS animation.
Enabling "WebAnimationsCSSIntegrationEnabled" overrides the CSSAnimationController to use WebAnimation which is not used in our port (JAVA) and we are using KeyFrameAnimation.
Test : need to run DRT test harness with this fix for "LayoutTests/animations".
Progress
Issue
JDK-8237003: Remove hardcoded WebAnimationsCSSIntegrationEnabled flag in DumpRenderTree
Approvers