Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8237003: Remove hardcoded WebAnimationsCSSIntegrationEnabled flag in DumpRenderTree #100

Closed
wants to merge 1 commit into from

Conversation

@guruhb
Copy link
Contributor

guruhb commented Jan 29, 2020

AnimationBase and WebAnimation are two different abstract animation API provider. By default KeyFrameAnimation (which is a sub class of AnimationBase) is used for controlling and rendering the CSS animation.
Enabling "WebAnimationsCSSIntegrationEnabled" overrides the CSSAnimationController to use WebAnimation which is not used in our port (JAVA) and we are using KeyFrameAnimation.

Test : need to run DRT test harness with this fix for "LayoutTests/animations".

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

JDK-8237003: Remove hardcoded WebAnimationsCSSIntegrationEnabled flag in DumpRenderTree

Approvers

  • Kevin Rushforth (kcr - Reviewer)
@guruhb guruhb requested a review from kevinrushforth Jan 29, 2020
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 29, 2020

👋 Welcome back ghb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Jan 29, 2020
@mlbridge
Copy link

mlbridge bot commented Jan 29, 2020

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 29, 2020

@guruhb This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8237003: Remove hardcoded WebAnimationsCSSIntegrationEnabled flag in DumpRenderTree

Reviewed-by: kcr
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 4 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to do this manually, please merge master into your branch first.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 29, 2020
@kevinrushforth
Copy link
Member

kevinrushforth commented Jan 29, 2020

This fix only affects the test framework, so a single reviewer is fine.

@guruhb
Copy link
Contributor Author

guruhb commented Jan 29, 2020

/integrate

@openjdk openjdk bot closed this Jan 29, 2020
@openjdk openjdk bot added integrated and removed ready labels Jan 29, 2020
@openjdk
Copy link

openjdk bot commented Jan 29, 2020

@guruhb The following commits have been pushed to master since your change was applied:

  • d303a21: Merge
  • 5a0e71b: 8237372: NullPointerException in TabPaneSkin.stopDrag
  • 79fc0d0: 8232824: Removing TabPane with strong referenced content causes memory leak from weak one
  • aa6f3a4: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5

Your commit was automatically rebased without conflicts.

Pushed as commit b96bc52.

@mlbridge
Copy link

mlbridge bot commented Jan 29, 2020

Mailing list message from Guru Hb on openjfx-dev:

Changeset: b96bc52
Author: Guru Hb <ghb at openjdk.org>
Date: 2020-01-29 16:44:56 +0000
URL: https://git.openjdk.java.net/jfx/commit/b96bc52b

8237003: Remove hardcoded WebAnimationsCSSIntegrationEnabled flag in DumpRenderTree

Reviewed-by: kcr

! modules/javafx.web/src/main/java/com/sun/javafx/webkit/drt/DumpRenderTree.java

@kevinrushforth kevinrushforth removed the rfr label Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.