-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8296654: [macos] Crash when launching JavaFX app with JDK that targets SDK 13 #1003
Conversation
…s SDK 13 Reviewed-by: aghaisas, jvos, mstrauss
👋 Welcome back jvos! A progress list of the required criteria for merging this PR into |
@johanvos I think that "Backport" must be capitalized in the PR title (not 100% sure, but it seems like Skara doesn't recognize this as a backport). |
This backport pull request has now been updated with issue from the original commit. |
/integrate |
@johanvos This pull request has not yet been marked as ready for integration. |
@johanvos This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 795ed10. |
8296654: [macos] Crash when launching JavaFX app with JDK that targets SDK 13
Reviewed-by: aghaisas, jvos, mstrauss
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/1003/head:pull/1003
$ git checkout pull/1003
Update a local copy of the PR:
$ git checkout pull/1003
$ git pull https://git.openjdk.org/jfx pull/1003/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1003
View PR using the GUI difftool:
$ git pr show -t 1003
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1003.diff