Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296654: [macos] Crash when launching JavaFX app with JDK that targets SDK 13 #1003

Closed
wants to merge 1 commit into from

Conversation

johanvos
Copy link
Collaborator

@johanvos johanvos commented Jan 19, 2023

8296654: [macos] Crash when launching JavaFX app with JDK that targets SDK 13

Reviewed-by: aghaisas, jvos, mstrauss


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8296654: [macos] Crash when launching JavaFX app with JDK that targets SDK 13

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/1003/head:pull/1003
$ git checkout pull/1003

Update a local copy of the PR:
$ git checkout pull/1003
$ git pull https://git.openjdk.org/jfx pull/1003/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1003

View PR using the GUI difftool:
$ git pr show -t 1003

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1003.diff

…s SDK 13

Reviewed-by: aghaisas, jvos, mstrauss
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 19, 2023

👋 Welcome back jvos! A progress list of the required criteria for merging this PR into jfx19 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@kevinrushforth
Copy link
Member

@johanvos I think that "Backport" must be capitalized in the PR title (not 100% sure, but it seems like Skara doesn't recognize this as a backport).

@johanvos johanvos changed the title backport 5b96d348ebcabb4b6d2e1d95937de3c82a1f6876 Backport 5b96d348ebcabb4b6d2e1d95937de3c82a1f6876 Jan 19, 2023
@openjdk openjdk bot changed the title Backport 5b96d348ebcabb4b6d2e1d95937de3c82a1f6876 8296654: [macos] Crash when launching JavaFX app with JDK that targets SDK 13 Jan 19, 2023
@openjdk
Copy link

openjdk bot commented Jan 19, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Ready for review labels Jan 19, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 19, 2023

Webrevs

@johanvos
Copy link
Collaborator Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 19, 2023

@johanvos This pull request has not yet been marked as ready for integration.

@openjdk
Copy link

openjdk bot commented Jan 19, 2023

@johanvos This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296654: [macos] Crash when launching JavaFX app with JDK that targets SDK 13

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jfx19 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jfx19 branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Jan 19, 2023
@johanvos
Copy link
Collaborator Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 19, 2023

Going to push as commit 795ed10.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 19, 2023
@openjdk openjdk bot closed this Jan 19, 2023
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Jan 19, 2023
@openjdk
Copy link

openjdk bot commented Jan 19, 2023

@johanvos Pushed as commit 795ed10.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants