-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8299977 : Update WebKit to 615.1 #1011
Conversation
👋 Welcome back hmeda! A progress list of the required criteria for merging this PR into |
@HimaBinduMeda |
Webrevs
|
/reviewers 2 |
@kevinrushforth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'll re-approve once you remove the comment and print statement from ImageBufferBackend.h
that you mentioned in the description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Building and testing succeeded on linux, mac and windows x86_64.
@tiainen Can you re-review following Hima's removal of the print statement? |
@HimaBinduMeda This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@HimaBinduMeda |
/sponsor |
Going to push as commit 301bbd6. |
@kevinrushforth @HimaBinduMeda Pushed as commit 301bbd6. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Update JavaFX WebKit to GTK WebKit 2.38 (615.1).
Verified the updated version build, sanity tests and stability.
This does not cause any issues except one unit test failure.
Also, there are some artifacts observed while playing youtube
The above issues are recorded and ignored using below bugs:
JDK-8300954
JDK-8301022
/contributor add jbhaskar
Note to reviewers:
The comment in ImageBufferBackend.h is not removed intentionally. This log should not be seen during the testing.Will remove this log before integration.
Progress
Issue
Reviewers
Contributors
<jbhaskar@openjdk.org>
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/1011/head:pull/1011
$ git checkout pull/1011
Update a local copy of the PR:
$ git checkout pull/1011
$ git pull https://git.openjdk.org/jfx pull/1011/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1011
View PR using the GUI difftool:
$ git pr show -t 1011
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1011.diff