Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8299977 : Update WebKit to 615.1 #1011

Closed
wants to merge 3 commits into from

Conversation

HimaBinduMeda
Copy link
Contributor

@HimaBinduMeda HimaBinduMeda commented Jan 25, 2023

Update JavaFX WebKit to GTK WebKit 2.38 (615.1).

Verified the updated version build, sanity tests and stability.
This does not cause any issues except one unit test failure.
Also, there are some artifacts observed while playing youtube

The above issues are recorded and ignored using below bugs:
JDK-8300954
JDK-8301022

/contributor add jbhaskar

Note to reviewers:
The comment in ImageBufferBackend.h is not removed intentionally. This log should not be seen during the testing.Will remove this log before integration.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

Reviewers

Contributors

  • Jay Bhaskar <jbhaskar@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/1011/head:pull/1011
$ git checkout pull/1011

Update a local copy of the PR:
$ git checkout pull/1011
$ git pull https://git.openjdk.org/jfx pull/1011/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1011

View PR using the GUI difftool:
$ git pr show -t 1011

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1011.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 25, 2023

👋 Welcome back hmeda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Jan 25, 2023
@openjdk
Copy link

openjdk bot commented Jan 25, 2023

@HimaBinduMeda
Contributor Jay Bhaskar <jbhaskar@openjdk.org> successfully added.

@mlbridge
Copy link

mlbridge bot commented Jan 25, 2023

Webrevs

@kevinrushforth
Copy link
Member

/reviewers 2

@openjdk
Copy link

openjdk bot commented Jan 26, 2023

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll re-approve once you remove the comment and print statement from ImageBufferBackend.h that you mentioned in the description.

Copy link
Collaborator

@tiainen tiainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Building and testing succeeded on linux, mac and windows x86_64.

@kevinrushforth
Copy link
Member

@tiainen Can you re-review following Hima's removal of the print statement?

@openjdk
Copy link

openjdk bot commented Feb 1, 2023

@HimaBinduMeda This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299977: Update WebKit to 615.1

Co-authored-by: Jay Bhaskar <jbhaskar@openjdk.org>
Reviewed-by: kcr, sykora

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Ready to be integrated label Feb 1, 2023
@HimaBinduMeda
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Ready to sponsor label Feb 1, 2023
@openjdk
Copy link

openjdk bot commented Feb 1, 2023

@HimaBinduMeda
Your change (at version a804a6e) is now ready to be sponsored by a Committer.

@kevinrushforth
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 1, 2023

Going to push as commit 301bbd6.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 1, 2023
@openjdk openjdk bot closed this Feb 1, 2023
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Feb 1, 2023
@openjdk openjdk bot removed the sponsor Ready to sponsor label Feb 1, 2023
@openjdk
Copy link

openjdk bot commented Feb 1, 2023

@kevinrushforth @HimaBinduMeda Pushed as commit 301bbd6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants