Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8300705: Update boot JDK to 19.0.2 #1019

Closed
wants to merge 1 commit into from

Conversation

arapte
Copy link
Member

@arapte arapte commented Feb 1, 2023

Updating boot JDK to 19.0.2.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/1019/head:pull/1019
$ git checkout pull/1019

Update a local copy of the PR:
$ git checkout pull/1019
$ git pull https://git.openjdk.org/jfx pull/1019/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1019

View PR using the GUI difftool:
$ git pr show -t 1019

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1019.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 1, 2023

👋 Welcome back arapte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Feb 1, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 1, 2023

Webrevs

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Since it is just updating to a new update in the JDK 19 family (from 19.0.1 to 19.0.2), a single reviewer should be sufficient.

You might wait until tomorrow (as long as it is before RDP2) to integrate it in case @johanvos has any concerns.

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I just noticed that this is targeted to master. It should be targeted to jfx20.

@kevinrushforth
Copy link
Member

And since it is based off of master, you will need to rebase on top of jfx20 and force-push.

@arapte arapte changed the base branch from master to jfx20 February 2, 2023 02:14
@openjdk
Copy link

openjdk bot commented Feb 2, 2023

@arapte Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now.

@openjdk
Copy link

openjdk bot commented Feb 2, 2023

@arapte This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300705: Update boot JDK to 19.0.2

Reviewed-by: kcr, jvos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the jfx20 branch:

  • 39d8747: 8290863: Update the documentation of Virtualized controls to include the best practice of not using Nodes directly in the item list

Please see this link for an up-to-date comparison between the source branch of this pull request and the jfx20 branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jfx20 branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Feb 2, 2023
@johanvos
Copy link
Collaborator

johanvos commented Feb 2, 2023

Looks good

@arapte
Copy link
Member Author

arapte commented Feb 2, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Feb 2, 2023

Going to push as commit 8f2fac0.
Since your change was applied there has been 1 commit pushed to the jfx20 branch:

  • 39d8747: 8290863: Update the documentation of Virtualized controls to include the best practice of not using Nodes directly in the item list

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 2, 2023
@openjdk openjdk bot closed this Feb 2, 2023
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Feb 2, 2023
@openjdk
Copy link

openjdk bot commented Feb 2, 2023

@arapte Pushed as commit 8f2fac0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@arapte arapte deleted the boot-jdk-19-0-2 branch February 2, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
3 participants