New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8300705: Update boot JDK to 19.0.2 #1019
Conversation
👋 Welcome back arapte! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Since it is just updating to a new update in the JDK 19 family (from 19.0.1 to 19.0.2), a single reviewer should be sufficient.
You might wait until tomorrow (as long as it is before RDP2) to integrate it in case @johanvos has any concerns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I just noticed that this is targeted to master
. It should be targeted to jfx20
.
And since it is based off of master, you will need to rebase on top of |
d3bd73c
to
f9f634b
Compare
@arapte Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good now.
@arapte This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Looks good |
/integrate |
Going to push as commit 8f2fac0.
Your commit was automatically rebased without conflicts. |
Updating boot JDK to 19.0.2.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/1019/head:pull/1019
$ git checkout pull/1019
Update a local copy of the PR:
$ git checkout pull/1019
$ git pull https://git.openjdk.org/jfx pull/1019/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1019
View PR using the GUI difftool:
$ git pr show -t 1019
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1019.diff