8301712: [linux] Crash on exit from WebKit 615.1

[jaybhaskar]

Issue: [linux] Crash on exit from WebKit 615.1 Crash dump observed on Window exit
Root cause: Accessing local storage data of a thread having client data like font cache during VM shutdown
Solution: Add a shutdown hook to ThreadTimers class, so that no timer class doesn't fire any function during the shutdown.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8301712: [linux] Crash on exit from WebKit 615.1

Reviewers

• Kevin Rushforth (@kevinrushforth - Reviewer)
• Hima Bindu Meda (@HimaBinduMeda - Author)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/1027/head:pull/1027
$ git checkout pull/1027

Update a local copy of the PR:
$ git checkout pull/1027
$ git pull https://git.openjdk.org/jfx pull/1027/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1027

View PR using the GUI difftool:
$ git pr show -t 1027

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1027.diff

[bridgekeeper]

👋 Welcome back jbhaskar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (02b0b0d6)

[kevinrushforth]

/reviewers 2

[openjdk]

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[kevinrushforth]

Reviewers: @kevinrushforth @HimaBinduMeda

[kevinrushforth]

The fix looks good to me. I confirm that it fixes the problem. I'll do a bit more testing before I approve.

[HimaBinduMeda]

Fix looks good to me. Tested on Mac and windows.No crash is observed with the fix.

[openjdk]

@jaybhaskar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301712: [linux] Crash on exit from WebKit 615.1

Reviewed-by: kcr, hmeda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 73ed7b6: 8290092: Temporary files are kept when call Clipboard.getSystemClipboard().getImage()

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[jaybhaskar]

/integrate

[openjdk]

@jaybhaskar
Your change (at version 02b0b0d) is now ready to be sponsored by a Committer.

[kevinrushforth]

/sponsor

[openjdk]

Going to push as commit 13d8df3.
Since your change was applied there has been 1 commit pushed to the master branch:

• 73ed7b6: 8290092: Temporary files are kept when call Clipboard.getSystemClipboard().getImage()

Your commit was automatically rebased without conflicts.

[openjdk]

@kevinrushforth @jaybhaskar Pushed as commit 13d8df3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.