Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8237503: Update copyright header for files modified in 2020 #103

Closed

Conversation

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Jan 31, 2020

Fix for JDK-8237503 to update the "last modified" year in the copyright header for all files modified in 2020 in the jfx14 branch.

NOTE: I'll update this to pick up any last-minute changes integrated to jfx14 and then remove the WIP.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

JDK-8237503: Update copyright header for files modified in 2020

Approvers

  • Ambarish Rapte (arapte - Reviewer)
@kevinrushforth kevinrushforth self-assigned this Jan 31, 2020
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 31, 2020

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into jfx14 will be added to the body of your pull request.

@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Jan 31, 2020

@arapte you can take an initial look whenever you are ready. I expect only a few new files to come in, which I will push as an additional commit.

@arapte
Copy link
Member

@arapte arapte commented Feb 3, 2020

Hi @kevinrushforth , The file list looks good.

@kevinrushforth kevinrushforth changed the title WIP: 8237503: Update copyright header for files modified in 2020 8237503: Update copyright header for files modified in 2020 Feb 3, 2020
@openjdk openjdk bot added the rfr label Feb 3, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 3, 2020

Webrevs

@arapte
arapte approved these changes Feb 3, 2020
Copy link
Member

@arapte arapte left a comment

Looks good to me.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 3, 2020

@kevinrushforth This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8237503: Update copyright header for files modified in 2020

Reviewed-by: arapte
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 3, 2020
@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Feb 3, 2020

/integrate

@openjdk openjdk bot closed this Feb 3, 2020
@openjdk openjdk bot added integrated and removed ready labels Feb 3, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Feb 3, 2020

@kevinrushforth
Pushed as commit a4b9f24.

@openjdk openjdk bot removed the rfr label Feb 3, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 3, 2020

Mailing list message from Kevin Rushforth on openjfx-dev:

Changeset: a4b9f24
Author: Kevin Rushforth <kcr at openjdk.org>
Date: 2020-02-03 15:48:52 +0000
URL: https://git.openjdk.java.net/jfx/commit/a4b9f24e

8237503: Update copyright header for files modified in 2020

Reviewed-by: arapte

! buildSrc/android.gradle
! modules/javafx.controls/src/main/java/javafx/scene/control/skin/TabPaneSkin.java
! modules/javafx.controls/src/test/java/test/javafx/scene/control/TabPaneTest.java
! modules/javafx.graphics/src/main/java/com/sun/glass/ui/android/DalvikInput.java
! modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/AndroidInputDeviceRegistry.java
! modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/AndroidPlatform.java
! modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/DispmanPlatform.java
! modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/HeadlessPlatform.java
! modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/LinuxPlatform.java
! modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/MX6Platform.java
! modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/MonocleApplication.java
! modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/NativePlatform.java
! modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/OMAPPlatform.java
! modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/X11Platform.java
! modules/javafx.graphics/src/main/java/com/sun/scenario/animation/shared/ClipEnvelope.java
! modules/javafx.graphics/src/main/java/com/sun/scenario/animation/shared/FiniteClipEnvelope.java
! modules/javafx.graphics/src/main/java/com/sun/scenario/animation/shared/InfiniteClipEnvelope.java
! modules/javafx.graphics/src/main/java/com/sun/scenario/animation/shared/SingleLoopClipEnvelope.java
! modules/javafx.graphics/src/main/java/javafx/animation/Animation.java
! modules/javafx.graphics/src/main/java/javafx/scene/Scene.java
! modules/javafx.graphics/src/main/java/javafx/scene/text/Text.java
! modules/javafx.graphics/src/main/native-glass/gtk/GlassApplication.cpp
! modules/javafx.graphics/src/main/native-glass/gtk/glass_dnd.cpp
! modules/javafx.graphics/src/main/native-glass/gtk/glass_dnd.h
! modules/javafx.graphics/src/main/native-glass/gtk/glass_general.cpp
! modules/javafx.graphics/src/main/native-glass/gtk/glass_window.cpp
! modules/javafx.graphics/src/main/native-glass/monocle/EGL.c
! modules/javafx.graphics/src/main/native-glass/monocle/android/AndroidScreen.c
! modules/javafx.graphics/src/main/native-glass/monocle/android/dalvikUtils.c
! modules/javafx.graphics/src/main/native-glass/monocle/android/nativeBridge.c
! modules/javafx.graphics/src/main/native-glass/monocle/dispman/DispmanScreen.c
! modules/javafx.graphics/src/main/native-iio/jpegloader.c
! modules/javafx.graphics/src/main/native-prism-es2/monocle/MonocleGLFactory.c
! modules/javafx.graphics/src/main/native-prism-es2/monocle/eglUtils.c
! modules/javafx.graphics/src/shims/java/com/sun/scenario/animation/shared/SingleLoopClipEnvelopeShim.java
! modules/javafx.graphics/src/shims/java/javafx/animation/AnimationShim.java
! modules/javafx.graphics/src/test/java/test/javafx/animation/AnimationSetRateTest.java
! modules/javafx.graphics/src/test/java/test/javafx/animation/AnimationTest.java
! modules/javafx.graphics/src/test/java/test/javafx/animation/SequentialTransitionPlayTest.java
! modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioEqualizer.cpp
! modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioEqualizer.h
! modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioProcessor.h
! modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioProcessor.mm
! modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioSpectrumUnit.cpp
! modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioSpectrumUnit.h
! modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFSoundLevelUnit.cpp
! modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFSoundLevelUnit.h
! modules/javafx.web/src/main/java/javafx/scene/web/WebView.java
! modules/javafx.web/src/main/native/Source/WebCore/bindings/java/JavaDOMUtils.h
! modules/javafx.web/src/test/java/test/javafx/scene/web/DOMTest.java
! modules/javafx.web/src/test/java/test/javafx/scene/web/WebViewTest.java
! tests/system/src/test/java/test/javafx/scene/Snapshot2Test.java
! tests/system/src/test/java/test/robot/javafx/scene/dialog/DialogWithOwnerSizingTest.java

@kevinrushforth kevinrushforth deleted the kevinrushforth:8237503-copyr-2020 branch Feb 3, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 3, 2020

Mailing list message from Kevin Rushforth on openjfx-dev:

Changeset: a4b9f24
Author: Kevin Rushforth <kcr at openjdk.org>
Date: 2020-02-03 15:48:52 +0000
URL: https://git.openjdk.java.net/jfx/commit/a4b9f24e

8237503: Update copyright header for files modified in 2020

Reviewed-by: arapte

! buildSrc/android.gradle
! modules/javafx.controls/src/main/java/javafx/scene/control/skin/TabPaneSkin.java
! modules/javafx.controls/src/test/java/test/javafx/scene/control/TabPaneTest.java
! modules/javafx.graphics/src/main/java/com/sun/glass/ui/android/DalvikInput.java
! modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/AndroidInputDeviceRegistry.java
! modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/AndroidPlatform.java
! modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/DispmanPlatform.java
! modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/HeadlessPlatform.java
! modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/LinuxPlatform.java
! modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/MX6Platform.java
! modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/MonocleApplication.java
! modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/NativePlatform.java
! modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/OMAPPlatform.java
! modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/X11Platform.java
! modules/javafx.graphics/src/main/java/com/sun/scenario/animation/shared/ClipEnvelope.java
! modules/javafx.graphics/src/main/java/com/sun/scenario/animation/shared/FiniteClipEnvelope.java
! modules/javafx.graphics/src/main/java/com/sun/scenario/animation/shared/InfiniteClipEnvelope.java
! modules/javafx.graphics/src/main/java/com/sun/scenario/animation/shared/SingleLoopClipEnvelope.java
! modules/javafx.graphics/src/main/java/javafx/animation/Animation.java
! modules/javafx.graphics/src/main/java/javafx/scene/Scene.java
! modules/javafx.graphics/src/main/java/javafx/scene/text/Text.java
! modules/javafx.graphics/src/main/native-glass/gtk/GlassApplication.cpp
! modules/javafx.graphics/src/main/native-glass/gtk/glass_dnd.cpp
! modules/javafx.graphics/src/main/native-glass/gtk/glass_dnd.h
! modules/javafx.graphics/src/main/native-glass/gtk/glass_general.cpp
! modules/javafx.graphics/src/main/native-glass/gtk/glass_window.cpp
! modules/javafx.graphics/src/main/native-glass/monocle/EGL.c
! modules/javafx.graphics/src/main/native-glass/monocle/android/AndroidScreen.c
! modules/javafx.graphics/src/main/native-glass/monocle/android/dalvikUtils.c
! modules/javafx.graphics/src/main/native-glass/monocle/android/nativeBridge.c
! modules/javafx.graphics/src/main/native-glass/monocle/dispman/DispmanScreen.c
! modules/javafx.graphics/src/main/native-iio/jpegloader.c
! modules/javafx.graphics/src/main/native-prism-es2/monocle/MonocleGLFactory.c
! modules/javafx.graphics/src/main/native-prism-es2/monocle/eglUtils.c
! modules/javafx.graphics/src/shims/java/com/sun/scenario/animation/shared/SingleLoopClipEnvelopeShim.java
! modules/javafx.graphics/src/shims/java/javafx/animation/AnimationShim.java
! modules/javafx.graphics/src/test/java/test/javafx/animation/AnimationSetRateTest.java
! modules/javafx.graphics/src/test/java/test/javafx/animation/AnimationTest.java
! modules/javafx.graphics/src/test/java/test/javafx/animation/SequentialTransitionPlayTest.java
! modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioEqualizer.cpp
! modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioEqualizer.h
! modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioProcessor.h
! modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioProcessor.mm
! modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioSpectrumUnit.cpp
! modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioSpectrumUnit.h
! modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFSoundLevelUnit.cpp
! modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFSoundLevelUnit.h
! modules/javafx.web/src/main/java/javafx/scene/web/WebView.java
! modules/javafx.web/src/main/native/Source/WebCore/bindings/java/JavaDOMUtils.h
! modules/javafx.web/src/test/java/test/javafx/scene/web/DOMTest.java
! modules/javafx.web/src/test/java/test/javafx/scene/web/WebViewTest.java
! tests/system/src/test/java/test/javafx/scene/Snapshot2Test.java
! tests/system/src/test/java/test/robot/javafx/scene/dialog/DialogWithOwnerSizingTest.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.