Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8090647: Mnemonics : on windows we should cancel the underscore latch when an app loses focus. #1030

Closed

Conversation

hjohn
Copy link
Collaborator

@hjohn hjohn commented Feb 12, 2023

This fix hides mnemonics when the Scene's Window loses focus.

Before integration, we need to make sure this is correct behavior for Mac and Linux as well. It is correct for Windows.

How to test:

  • Create a control with a mnemonic
  • Alt-tab to another window (mnemonics appear when alt is pressed)

Before:

  • Window shows visible mnemonic still and reacts on them when returning

After:

  • Window hides mnemonics when focus is lost and doesn't react on them when returning

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8090647: Mnemonics : on windows we should cancel the underscore latch when an app loses focus.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/1030/head:pull/1030
$ git checkout pull/1030

Update a local copy of the PR:
$ git checkout pull/1030
$ git pull https://git.openjdk.org/jfx pull/1030/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1030

View PR using the GUI difftool:
$ git pr show -t 1030

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1030.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 12, 2023

👋 Welcome back jhendrikx! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Feb 12, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 12, 2023

Webrevs

@kevinrushforth
Copy link
Member

Can you provide a unit test?

Reviewers: @aghaisas @andy-goryachev-oracle

/reviewers 2

@openjdk
Copy link

openjdk bot commented Feb 15, 2023

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@andy-goryachev-oracle
Copy link
Contributor

Any idea how to Alt-Tab on Mac?

@kevinrushforth
Copy link
Member

The equivalent of ALT-TAB on macOS is CMD-TAB, but I don't know the bug can happen on macOS (it was reported on Windows).

@beldenfox
Copy link
Contributor

This bug doesn't affect macOS since it never enters a persistent mnemonic state (I just checked the sources).

Copy link
Contributor

@andy-goryachev-oracle andy-goryachev-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • verified on windows 11
  • no changes in behavior on mac os ventura 13.1 (as expected)

Copy link
Contributor

@andy-goryachev-oracle andy-goryachev-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Copy link
Collaborator

@aghaisas aghaisas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good to me!

@openjdk
Copy link

openjdk bot commented Feb 16, 2023

@hjohn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8090647: Mnemonics : on windows we should cancel the underscore latch when an app loses focus.

Reviewed-by: angorya, aghaisas

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 21aa630: 8284662: [Win][Accessibility][ListCell] Screen reader fails to read ListView/ComboBox item count if > 100
  • 67c2b7a: 8302684: Cherry-pick WebKit 615.1 stabilization fixes (2)
  • f4ca00d: 8281327: JavaFX does not support fonts installed per-user on Windows 10/11
  • dbab36b: 8300893: Wrong state after deselecting two or more cells of a TableView selection
  • 97ae4b8: 8302294: Cherry-pick WebKit 615.1 stabilization fixes
  • d1572f4: 8298528: Clean up raw type warnings in base in bindings and collections packages
  • de8339d: 8088998: XYChart: duplicate child added exception when remove & add a series in several charts

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Feb 16, 2023
@kevinrushforth
Copy link
Member

@hjohn you can integrate this when you are ready.

@hjohn
Copy link
Collaborator Author

hjohn commented Feb 22, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Feb 22, 2023

Going to push as commit 25e4ab9.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 315939f: 8302472: WebColorFieldSkin should use precompiled Pattern
  • 21aa630: 8284662: [Win][Accessibility][ListCell] Screen reader fails to read ListView/ComboBox item count if > 100
  • 67c2b7a: 8302684: Cherry-pick WebKit 615.1 stabilization fixes (2)
  • f4ca00d: 8281327: JavaFX does not support fonts installed per-user on Windows 10/11
  • dbab36b: 8300893: Wrong state after deselecting two or more cells of a TableView selection
  • 97ae4b8: 8302294: Cherry-pick WebKit 615.1 stabilization fixes
  • d1572f4: 8298528: Clean up raw type warnings in base in bindings and collections packages
  • de8339d: 8088998: XYChart: duplicate child added exception when remove & add a series in several charts

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 22, 2023
@openjdk openjdk bot closed this Feb 22, 2023
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Feb 22, 2023
@openjdk
Copy link

openjdk bot commented Feb 22, 2023

@hjohn Pushed as commit 25e4ab9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
5 participants