-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8302294 : Cherry-pick WebKit 615.1 stabilization fixes #1033
Conversation
👋 Welcome back hmeda! A progress list of the required criteria for merging this PR into |
Reviewers: @kevinrushforth and @johanvos or @tiainen @jaybhaskar Can you also take a look? /reviewers 2 |
@kevinrushforth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Building and testing succeeded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Tested on all three platforms.
@HimaBinduMeda This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@HimaBinduMeda |
/sponsor |
Going to push as commit 97ae4b8. |
@kevinrushforth @HimaBinduMeda Pushed as commit 97ae4b8. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Cherry-pick stabilisation fixes till 2.38.4.
Verified unit tests and drt. No issue observed.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/1033/head:pull/1033
$ git checkout pull/1033
Update a local copy of the PR:
$ git checkout pull/1033
$ git pull https://git.openjdk.org/jfx pull/1033/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1033
View PR using the GUI difftool:
$ git pr show -t 1033
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1033.diff