Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8302294 : Cherry-pick WebKit 615.1 stabilization fixes #1033

Closed
wants to merge 1 commit into from

Conversation

HimaBinduMeda
Copy link
Contributor

@HimaBinduMeda HimaBinduMeda commented Feb 14, 2023

Cherry-pick stabilisation fixes till 2.38.4.
Verified unit tests and drt. No issue observed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8302294: Cherry-pick WebKit 615.1 stabilization fixes

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/1033/head:pull/1033
$ git checkout pull/1033

Update a local copy of the PR:
$ git checkout pull/1033
$ git pull https://git.openjdk.org/jfx pull/1033/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1033

View PR using the GUI difftool:
$ git pr show -t 1033

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1033.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 14, 2023

👋 Welcome back hmeda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@HimaBinduMeda HimaBinduMeda marked this pull request as ready for review February 14, 2023 18:24
@openjdk openjdk bot added the rfr Ready for review label Feb 14, 2023
@kevinrushforth
Copy link
Member

Reviewers: @kevinrushforth and @johanvos or @tiainen

@jaybhaskar Can you also take a look?

/reviewers 2

@openjdk
Copy link

openjdk bot commented Feb 14, 2023

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@mlbridge
Copy link

mlbridge bot commented Feb 14, 2023

Webrevs

Copy link
Collaborator

@tiainen tiainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Building and testing succeeded.

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested on all three platforms.

@openjdk
Copy link

openjdk bot commented Feb 15, 2023

@HimaBinduMeda This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8302294: Cherry-pick WebKit 615.1 stabilization fixes

Reviewed-by: sykora, kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Ready to be integrated label Feb 15, 2023
@HimaBinduMeda
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Ready to sponsor label Feb 15, 2023
@openjdk
Copy link

openjdk bot commented Feb 15, 2023

@HimaBinduMeda
Your change (at version 933eff0) is now ready to be sponsored by a Committer.

@kevinrushforth
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 15, 2023

Going to push as commit 97ae4b8.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 15, 2023
@openjdk openjdk bot closed this Feb 15, 2023
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review sponsor Ready to sponsor labels Feb 15, 2023
@openjdk
Copy link

openjdk bot commented Feb 15, 2023

@kevinrushforth @HimaBinduMeda Pushed as commit 97ae4b8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants