Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8302684 : Cherry-pick WebKit 615.1 stabilization fixes (2) #1038

Closed
wants to merge 2 commits into from

Conversation

HimaBinduMeda
Copy link
Contributor

@HimaBinduMeda HimaBinduMeda commented Feb 16, 2023

Stabilization fixes from Webkitgtk-2.38.5.
Verified drt and unit tests. No issues observed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8302684: Cherry-pick WebKit 615.1 stabilization fixes (2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/1038/head:pull/1038
$ git checkout pull/1038

Update a local copy of the PR:
$ git checkout pull/1038
$ git pull https://git.openjdk.org/jfx pull/1038/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1038

View PR using the GUI difftool:
$ git pr show -t 1038

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1038.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 16, 2023

👋 Welcome back hmeda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Feb 16, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 16, 2023

Webrevs

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Testing is green.

@openjdk
Copy link

openjdk bot commented Feb 17, 2023

@HimaBinduMeda This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8302684: Cherry-pick WebKit 615.1 stabilization fixes (2)

Reviewed-by: kcr, sykora

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • f4ca00d: 8281327: JavaFX does not support fonts installed per-user on Windows 10/11
  • dbab36b: 8300893: Wrong state after deselecting two or more cells of a TableView selection

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Ready to be integrated label Feb 17, 2023
@kevinrushforth
Copy link
Member

/reviewers 2

@kevinrushforth
Copy link
Member

@tiainen or @johanvos could one of you be the second reviewer?

@openjdk
Copy link

openjdk bot commented Feb 17, 2023

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@openjdk openjdk bot removed the ready Ready to be integrated label Feb 17, 2023
Copy link
Collaborator

@tiainen tiainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Building and testing completed without issues.

@openjdk openjdk bot added the ready Ready to be integrated label Feb 17, 2023
@HimaBinduMeda
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Ready to sponsor label Feb 17, 2023
@openjdk
Copy link

openjdk bot commented Feb 17, 2023

@HimaBinduMeda
Your change (at version 08a32d7) is now ready to be sponsored by a Committer.

@kevinrushforth
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 17, 2023

Going to push as commit 67c2b7a.
Since your change was applied there have been 2 commits pushed to the master branch:

  • f4ca00d: 8281327: JavaFX does not support fonts installed per-user on Windows 10/11
  • dbab36b: 8300893: Wrong state after deselecting two or more cells of a TableView selection

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 17, 2023
@openjdk openjdk bot closed this Feb 17, 2023
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review sponsor Ready to sponsor labels Feb 17, 2023
@openjdk
Copy link

openjdk bot commented Feb 17, 2023

@kevinrushforth @HimaBinduMeda Pushed as commit 67c2b7a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
3 participants