8301022: Video distortion is observed while playing youtube video

[jaybhaskar]

Issue: current update is breaking the rendering of media controls on youtube video playback
For the Webkit Gtk platform, the layout class name is returned as AdwaitaLayoutTraits
which is incompatible with the JAVA platform.
Solution: Use mediaControlsAdwaitaJavaScript and mediaControlsAdwaitaUserAgentStyleSheet
which is compatible with RenderThemeJava.
Test: After the fix, open youtube.com and play any video, mouse hover on the video area, control should come up.
Without the fix, open youtube.com and play any video, mouse hover on the video area, and the control
should come up overlapping with each other.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8301022: Video distortion is observed while playing youtube video

Reviewers

• Kevin Rushforth (@kevinrushforth - Reviewer)
• Hima Bindu Meda (@HimaBinduMeda - Author)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/1045/head:pull/1045
$ git checkout pull/1045

Update a local copy of the PR:
$ git checkout pull/1045
$ git pull https://git.openjdk.org/jfx pull/1045/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1045

View PR using the GUI difftool:
$ git pr show -t 1045

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1045.diff

[bridgekeeper]

👋 Welcome back jbhaskar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 01: Full - Incremental (d7fef32c)
• 00: Full (a26dd884)

[kevinrushforth]

/reviewers 2

[openjdk]

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[kevinrushforth]

@HimaBinduMeda can you also review this?

[kevinrushforth]

Looks good. I tested on Windows and the media controls show up again.

Have you tested on both Mac and Linux?

[jaybhaskar]

tested on all platforms window/linux/mac

[HimaBinduMeda]

Looks good. Tested on mac and linux. The controls are rendered properly

[openjdk]

@jaybhaskar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301022: Video distortion is observed while playing youtube video

Reviewed-by: kcr, hmeda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• a3c2205: 8173321: TableView: Click on right trough has no effect when cell height is higher than viewport height
• 25e4ab9: 8090647: Mnemonics : on windows we should cancel the underscore latch when an app loses focus.
• 315939f: 8302472: WebColorFieldSkin should use precompiled Pattern

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[jaybhaskar]

/integrate

[openjdk]

@jaybhaskar
Your change (at version d7fef32) is now ready to be sponsored by a Committer.

[kevinrushforth]

/sponsor

[openjdk]

Going to push as commit 14883a2.
Since your change was applied there have been 3 commits pushed to the master branch:

• a3c2205: 8173321: TableView: Click on right trough has no effect when cell height is higher than viewport height
• 25e4ab9: 8090647: Mnemonics : on windows we should cancel the underscore latch when an app loses focus.
• 315939f: 8302472: WebColorFieldSkin should use precompiled Pattern

Your commit was automatically rebased without conflicts.

[openjdk]

@kevinrushforth @jaybhaskar Pushed as commit 14883a2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.