Skip to content

8303019: cssref.html incorrect internal link in Path #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

andy-goryachev-oracle
Copy link
Contributor

@andy-goryachev-oracle andy-goryachev-oracle commented Feb 23, 2023

documentation change
targeting jfx20 branch

  • fixed all incorrect references in "Also has all properties of ..."
  • added a link to Shape where it was missing
  • fixed chart -> Chart

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8303019: cssref.html incorrect internal link in Path

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/1046/head:pull/1046
$ git checkout pull/1046

Update a local copy of the PR:
$ git checkout pull/1046
$ git pull https://git.openjdk.org/jfx pull/1046/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1046

View PR using the GUI difftool:
$ git pr show -t 1046

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1046.diff

@andy-goryachev-oracle andy-goryachev-oracle marked this pull request as ready for review February 23, 2023 20:13
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 23, 2023

👋 Welcome back angorya! A progress list of the required criteria for merging this PR into jfx20 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Feb 23, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 23, 2023

Webrevs

@kevinrushforth kevinrushforth self-requested a review February 23, 2023 20:48
Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Since this is a simple bug fix that doesn't change any wording, a single reviewer is sufficient. Go ahead and integrate it into jfx20 when ready.

@openjdk
Copy link

openjdk bot commented Feb 24, 2023

@andy-goryachev-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303019: cssref.html incorrect internal link in Path

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jfx20 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jfx20 branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Feb 24, 2023
@andy-goryachev-oracle
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 24, 2023

Going to push as commit 1dd0a59.
Since your change was applied there has been 1 commit pushed to the jfx20 branch:

  • 7bf2372: 8293587: Fix mistakes in FX API docs

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 24, 2023
@openjdk openjdk bot closed this Feb 24, 2023
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Feb 24, 2023
@openjdk
Copy link

openjdk bot commented Feb 24, 2023

@andy-goryachev-oracle Pushed as commit 1dd0a59.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@andy-goryachev-oracle andy-goryachev-oracle deleted the 8303019.cssref branch February 24, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants