8303217: Webview loaded webpage is not showing play, volume related buttons for embeded Audio/Video elements #1049
Conversation
…uttons for embeded Audio/Video elements
|
👋 Welcome back jbhaskar! A progress list of the required criteria for merging this PR into |
jaybhaskar
changed the title
Webrevs
|
jaybhaskar
changed the title
|
with this pr default media control works excluding slider, slider might be solved with range input bug JDK-8300954 |
jaybhaskar
force-pushed
the
JDK-8302284
branch
from
adf1f1b
to
ca622c2
Compare
|
@jaybhaskar Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
|
/reviewers 2 |
|
@HimaBinduMeda Can you be the second reviewer? |
|
@kevinrushforth |
|
NOTE: This is a follow-on to JDK-8301022 which was fixed in PR #1045 |
|
/issue add JDK-8300954 |
|
@jaybhaskar |
|
/contributor hmeda@openjdk.org |
|
@jaybhaskar Syntax:
User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address. |
|
/contributor add hmeda@openjdk.org |
|
@jaybhaskar Syntax:
User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address. |
|
/contributor add hmeda |
|
@jaybhaskar |
|
With this fix slider and media, controls are being rendered but the thumb part of the slider is missing. The thumb issue could be filed as follow on bug based on the current analysis. The investigation is in progress to fix it. |
|
As a note to other reviewers, the fix for PR #1050 was folded into this fix. There were overlapping changes (merge conflicts), so it was easier to resolve them in a single PR. |
|
Looks good. I have verified unit tests and drt tests on mac and windows. |
|
@jaybhaskar This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 9 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit bbdc599.
Your commit was automatically rebased without conflicts. |
|
@jaybhaskar Pushed as commit bbdc599. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Issue: default html5 video element not showing media controls
Details: Media control design has been refactored in the current Webkit Gtk port. The CSS id
and properties related to media buttons, and slider have been removed, due to which the
media style mediaControlsAdwaita.css values are not being applied.
Solution: restored media control keywords and mapped to CSS keywords values.
Progress
Issues
Reviewers
Contributors
<hmeda@openjdk.org>Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/1049/head:pull/1049$ git checkout pull/1049Update a local copy of the PR:
$ git checkout pull/1049$ git pull https://git.openjdk.org/jfx pull/1049/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1049View PR using the GUI difftool:
$ git pr show -t 1049Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1049.diff