Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8238434: Ensemble: Update version of Lucene to 7.7.2 #105

Closed

Conversation

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Feb 4, 2020

Update the version of Lucene used by Ensemble to the latest release of Lucene 7 which is version 7.7.2.

Per the instructions in UPDATING-lucene.txt, I made the following changes:

  1. Bumped the version numbers from 7.7.1 to 7.7.2 in all needed places

I did not regenerate the index files, since only the bugfix number (the third digit) changed. It is the same major.minor release as before.

To test this: apply the patch, run gradle apps, launch Ensemble8, and search for a sample or JavaFX component in the upper-right search box.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

JDK-8238434: Ensemble: Update version of Lucene to 7.7.2

Approvers

@kevinrushforth kevinrushforth self-assigned this Feb 4, 2020
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 4, 2020

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Feb 4, 2020
@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Feb 4, 2020

@aghaisas can you review this?

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 4, 2020

Webrevs

@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Feb 4, 2020

I pushed a new commit that reverts the changes to the stored binary index files. There is no need to regenerate them when upgrading to a new version where only the bugfix number (the third digit) changes. This minimizes the churn and avoids modifying the binary index files needlessly. I added a note to this effect in the updated UPDATING-lucene.txt file.

@aghaisas
Copy link
Collaborator

@aghaisas aghaisas commented Feb 17, 2020

I applied this patch, built the apps and verified with Ensemble8 app.
Also, verified that it downloads lucene 7.7.2 during build.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 17, 2020

@kevinrushforth This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8238434: Ensemble: Update version of Lucene to 7.7.2

Reviewed-by: aghaisas
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 5 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate e98645932d0d7765988f21b09d6d121202281e02.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 17, 2020
@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Feb 18, 2020

/integrate

@openjdk openjdk bot closed this Feb 18, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 18, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Feb 18, 2020

@kevinrushforth The following commits have been pushed to master since your change was applied:

  • e986459: 8227619: Potential memory leak in javafx.scene.control.ListView
  • a74137a: 8236839: System menubar removed when other menubars are created or modified
  • 21d3b7e: 8237453: [TabPane] Incorrect arrow key traversal through tabs after reordering
  • e224e54: 8238526: Cherry pick GTK WebKit 2.26.3 changes
  • 6968e38: 8237469: Inherited styles don't update when node is moved

Your commit was automatically rebased without conflicts.

Pushed as commit b5e65ec.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 18, 2020

Mailing list message from Kevin Rushforth on openjfx-dev:

Changeset: b5e65ec
Author: Kevin Rushforth <kcr at openjdk.org>
Date: 2020-02-18 14:41:22 +0000
URL: https://git.openjdk.java.net/jfx/commit/b5e65ecc

8238434: Ensemble: Update version of Lucene to 7.7.2

Reviewed-by: aghaisas

! apps/samples/.classpath
! apps/samples/Ensemble8/UPDATING-lucene.txt
! apps/samples/Ensemble8/build.gradle
! apps/samples/Ensemble8/legal/lucene.md
! apps/samples/Ensemble8/nbproject/project.properties
! build.gradle

@kevinrushforth kevinrushforth deleted the kevinrushforth:8238434-lucene-7.7.2 branch Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.