Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8238526: Cherry pick GTK WebKit 2.26.3 changes #107

wants to merge 1 commit into from


Copy link

@guruhb guruhb commented Feb 6, 2020

Fix contains


  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed


JDK-8238526: Cherry pick GTK WebKit 2.26.3 changes


  • Kevin Rushforth (kcr - Reviewer)
  • Johan Vos (jvos - Reviewer)

Copy link

bridgekeeper bot commented Feb 6, 2020

👋 Welcome back ghb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr Ready for review label Feb 6, 2020
Copy link

mlbridge bot commented Feb 6, 2020


Copy link

/reviewers 2

Copy link

openjdk bot commented Feb 6, 2020

The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

Copy link

As part of the review, I did a sanity build / test on all three platforms. All looks good.

Copy link

johanvos commented Feb 6, 2020

build and basic checks ok on mac/linux/win64. Didn't test on win32.

Copy link

openjdk bot commented Feb 6, 2020

@guruhb This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8238526: Cherry pick GTK WebKit 2.26.3 changes

Reviewed-by: kcr, jvos
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 6968e38da0e1f36b8aa63ec3c2ee91e4163b4b22.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Feb 6, 2020
Copy link
Contributor Author

guruhb commented Feb 7, 2020


@openjdk openjdk bot closed this Feb 7, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Ready to be integrated rfr Ready for review labels Feb 7, 2020
Copy link

openjdk bot commented Feb 7, 2020

@guruhb The following commits have been pushed to master since your change was applied:

  • 6968e38: 8237469: Inherited styles don't update when node is moved

Your commit was automatically rebased without conflicts.

Pushed as commit e224e54.

Copy link

mlbridge bot commented Feb 7, 2020

Mailing list message from Guru Hb on openjfx-dev:

Changeset: e224e54
Author: Guru Hb <ghb at>
Date: 2020-02-07 02:13:15 +0000

8238526: Cherry pick GTK WebKit 2.26.3 changes

Reviewed-by: kcr, jvos

! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGObjectAllocationSinkingPhase.cpp
! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGValidate.cpp
! modules/javafx.web/src/main/native/Source/JavaScriptCore/offlineasm/parser.rb
! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/NativeErrorConstructor.h
! modules/javafx.web/src/main/native/Source/WTF/wtf/Platform.h
! modules/javafx.web/src/main/native/Source/WTF/wtf/URLHelpers.cpp
! modules/javafx.web/src/main/native/Source/WebCore/dom/Document.cpp
! modules/javafx.web/src/main/native/Source/WebCore/page/FrameView.cpp
! modules/javafx.web/src/main/native/Source/WebCore/page/Page.cpp
! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/ComplexTextController.cpp
! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp
! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp
! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderFrameSet.cpp
! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderThemeGtk.cpp
! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderThemeGtk.h
! modules/javafx.web/src/main/native/Source/WebCore/rendering/SimpleLineLayoutResolver.cpp
! modules/javafx.web/src/main/native/Source/WebCore/svg/properties/SVGAnimatedPropertyPairAccessor.h
! modules/javafx.web/src/main/native/Source/WebCore/testing/InternalSettings.cpp
! modules/javafx.web/src/main/native/Source/cmake/OptionsGTK.cmake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
integrated Pull request has been integrated
3 participants