Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8305709: [testbug] Tree/TableViewResizeColumnToFitContentTest fails with fractional screen scale #1102

Conversation

andy-goryachev-oracle
Copy link
Contributor

@andy-goryachev-oracle andy-goryachev-oracle commented Apr 19, 2023

Skipping the test until JDK-8299753 is implemented.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8305709: [testbug] Tree/TableViewResizeColumnToFitContentTest fails with fractional screen scale

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1102/head:pull/1102
$ git checkout pull/1102

Update a local copy of the PR:
$ git checkout pull/1102
$ git pull https://git.openjdk.org/jfx.git pull/1102/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1102

View PR using the GUI difftool:
$ git pr show -t 1102

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1102.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 19, 2023

👋 Welcome back angorya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@andy-goryachev-oracle andy-goryachev-oracle marked this pull request as ready for review April 19, 2023 23:22
@openjdk openjdk bot added the rfr Ready for review label Apr 19, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 19, 2023

Webrevs

Copy link
Collaborator

@aghaisas aghaisas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@openjdk
Copy link

openjdk bot commented Apr 20, 2023

@andy-goryachev-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305709: [testbug] Tree/TableViewResizeColumnToFitContentTest fails with fractional screen scale

Reviewed-by: aghaisas

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Apr 20, 2023
Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check for whether or not this is a fractional scale looks fine. However, you need to file a new JBS Bug and use that new bug to skip this test. Unless the test fundamentally cannot ever work with fractional scales (which I don't think is the case), skipping it on a system with a fractional scale is meant to be temporary until the bug (JDK-8305709) is fixed, rather than being a fix for that bug. You should list JDK-8305709 in a comment as the reason for skipping the test (see inline).

Assert.assertEquals("TableView.CONSTRAINED_RESIZE_POLICY ignored.",
colsWidthBeforeResize, colsWidthAfterResize, 0);

if (!Util.isFractionalScale(table)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment with the bug ID of the bug that is the reason for skipping this part of the test. Something like:

    // Skip this check on platforms with fractional scale until JDK-8305709 is fixed

@andy-goryachev-oracle
Copy link
Contributor Author

closing this PR per Kevin's instructions, will resubmit under a different JBS ticket.

@andy-goryachev-oracle andy-goryachev-oracle deleted the 8305709.fractional.scale branch April 20, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Ready to be integrated rfr Ready for review
3 participants